-
Notifications
You must be signed in to change notification settings - Fork 540
[PORT] Prize Counter from Imp/EE #4309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* problem for future me * i dont want to work on this actually * Jesus Christ * polish pass * fuccck i thought i checked that
RSI Diff Bot; head commit 01ea010 merging into 42b93f4 Resources/Textures/_EE/Structures/Machines/prizecounter.rsi
Resources/Textures/_Impstation/Objects/Fun/prizeticket.rsi
|
24h |
- type: latheRecipe | ||
parent: BaseLightRecipe | ||
id: GlowstickRed | ||
result: GlowstickRed | ||
materials: | ||
Plastic: 50 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this?
If it's part of the port, document it with a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, whoops, i misinterpreted why imp had touched it. fixed
result: GlowstickRed | ||
materials: | ||
Plastic: 50 | ||
|
||
- type: latheRecipe | ||
parent: GlowstickRed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parent of the Flare is removed above, so this will not work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Steel: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untouch this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- ToySkeleton | ||
- ToyRenault | ||
- ToySiobhan | ||
- # End DeltaV additions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing start deltaV additions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
These are cool, direction approved. |
About the PR
You now get prize tickets from arcade machines, which can be traded in at the Prize Counter for specific toys. There are also Prize Balls which cargo can order, which give random prizes when opened.
I plan on making some more decor/machines for the arcade, so it would be nice to have tickets.
Why / Balance
Fun!
Technical details
Currently, I'm getting an error I don't fully understand ("Null value provided for reading but type was not nullable!" ?????) on the prize counter, so I'll need help with that... but otherwise, it works. Extreme YML tedium, so let me know if I messed anything up.
Media
Requirements
Changelog
🆑