Revert "Solaris midi fix" #4311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ae963ba.
github-actions
bot
added
Changes: YML
|
Hi, original author of the pr here, while yes i did request for this to be unmerged, I humbly ask that this not be unmerged until the next upstream merge (or whenever that new soundfont from upstream gets merged if someone wants to merge it early), otherwise it may ruin a good chunk of midis until said upstream merge occurs. |
|
No need to merge this now. I'll include this in the next upstream merge I'll do, which is still at least two weeks away since I'm really busy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2041
fixes #4310