Psionics #44
Psionics #44
Conversation
It's a ton of stuff relating to the basic Psionics system and all the powers. I'm saving this as a bit of a sanity check before moving forward. Left to do: 1. Implementing the Psionic faction so that the chat works as intended. 2. Adding the start-state cooldown timers to the actions.
github-actions
bot
added
Changes: Sprites
Changes: UI
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Got the psionic chat working. Got some other stuff working
The last batch of content.
This reverts commit c0cf35d.
This reverts commit c4dc828.
It's a ton of stuff relating to the basic Psionics system and all the powers. I'm saving this as a bit of a sanity check before moving forward. Left to do: 1. Implementing the Psionic faction so that the chat works as intended. 2. Adding the start-state cooldown timers to the actions.
Got the psionic chat working. Got some other stuff working
The last batch of content.
Got the psionic chat working. Got some other stuff working
With these changes in place, the unit does not work. Recording them so i don't lose my work.
Dawn of the final Commit. Rebase completed.
|
I'm ready for other human beings to look at this. I think. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…least, the integrator test won't psas.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: PHCodes <[email protected]>
|
Merge conflict because @FluffiestFloof also added DogVision |
|
There is literally so much I'd have to test I'd rather just merge it and see what breaks first lol |
There was a problem hiding this comment.
Theres a lot not marked properly as changed we made.
Anything changed should for single lines have a comment in the format DeltaV - Summary or Nyano - Summary
Or for large blocks of code, DeltaV/Nyano - Summary - Begin modified code block and DeltaV/Nyano - End modified code block
This way we can keep everything more maintainable by not having to blame something to see if its a local change or not
|
It'd be easier to review if this was split into multiple smaller prs, but seeing as I don't want to put more work on you, just adding the comments to base files should be enough for now. Any other issues can be worked on later |
I have added many comments to the base files, as requested. |
|
Fixed, but properly this time. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Colin-Tel <[email protected]>
Whats the worst that could happen |
…on#44) <details><summary><h1>Media</h1></summary> <p>  </p> </details>
It's a ton of stuff relating to the basic Psionics system and all the powers.
The merge is completed.
There is still some issues with Invisibility. I commented out the line that makes it so that people who were able to see the invisible who are now unable to toggles so that they can't. Something to do with the bit shifting being off now that it's been changed from an unsigned integer to an integer. The fault in our bits.
Here's a short list of the things I implemented, or tried to at least:
All of the Psionic powers (except mime's).
Got the glimmer probers working and glowing (I uh, think. They hum and raise glimmer at least. no construction, though).
Noospheric Storm and all other psionic-related game rules (events) implemented.
Added the PotentiallyPsionic tag to every morphotype I could (don't know if Vulpakin got it/will need to be added if we're missing any other races).
Got the Psionic faction chat working. (MOST of the existing upstream code edits were related to this. Was sad. And bad. Need .yml configurations for our chat channels!)
Liquids. Mind Breaker and Cryptobiolin should now interact as they're supposed to for Psionics. Prometheum and Lapothogoi oil should be implemented.
Psionic dream whispering.
Probably a bunch of other stuff I'm forgetting about. Note that I only really tested the Faction chat, Dreams, Powers, Probers, and the Game Rules extensively. Everything else was thrown on when I spotted it but in the interest of time I decided to move forward.
Anyway, here's a short list of the psionically-tangent things I noted but for the sake of my sanity didn't mess with:
About the PR
I put almost everything that makes psionic systems work and some of their minor features and powers back into the game.
Why / Balance
Needed to reintroduce psionics.
The rebase code had no psionics.
Technical details
Reimplements the code from Nyanotrasen. The biggest difference between old and new is the Actions system rework.
Media
I'm tired man. Here's the powers.
Breaking changes
It builds. As far as I know there are no breaking changes.
Changelog
🆑