-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angle Returns! #722
Angle Returns! #722
Conversation
This PR contains new or changed maps: 01/28/24 16:53 |
love when map render decides to not work when making a major map change |
Because this pr is lacking a valid station prototype |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing everything required to function as a game map, converting to draft so actions usage isn't used on this
just need to confirm with velcro which shuttle to use, forgot about that :O |
not sure what it doesn't like about Line 2 |
Will fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File changes look fine to me, job slots and the actual map will require Velcro's approval
@IamVelcroboy Have these issues been resolved yet? |
it needs a minor lighting pass that i'm still making my way through |
Review was done in Discord. Waiting for the changes requested there to be made. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Danger Revolution! <[email protected]>
Signed-off-by: Danger Revolution! <[email protected]>
Signed-off-by: Danger Revolution! <[email protected]>
@DangerRevolution is this real or fake |
It's missing Shipyard and a few misc changes, but is 99% done last I was doing it. But it realistically needs a complete lighting overhaul and probably a ground-up remake as there's literally no room for Justice or any new rooms that are needed. I mean, I could illegally expand the station using galvanised square steel and some screws from my aunt but then the Justice Department would look wack and out of place and not Angle-y |
justice shittle that flies around independently |
This is the last review I did on the map. If it is confirmed that the stuff in the review has been addressed, or it is addressed in another update, I will review again from there. Discord Review |
I addressed 99% of the issues you brought up in the review; not sure if it's pushed to remote. Waiting on #721 to be merged and the follow-ups before I get back to this. |
The age old question... Security borgs has been merged; Did Danger ever get back to this? It's been such a hot minute this has been touched, and Fox picked up Angle in that time, to my knowledge |
No; I haven't touched it, and have no plans to. |
Noted, thanks for informing us. |
About the PR
Why / Balance
I like Angle, Colin didn't want to do it due to the department moving required, so I remapped it.
Media
Refer to the map render :O
Changelog
🆑 DangerRevolution