Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home run bat #823

Closed
wants to merge 10 commits into from
Closed

Conversation

musicmanvr
Copy link
Contributor

About the PR

Adds the Syndicate Home Run Bat, a highly unusual weapon designed only the craziest of operatives.

On hit, it launches a target like a gorilla gaunlet, but at triple the speed, doing 30 brute while also doing heavy structural damage.

Why / Balance

Syndicate melee weaponry in the high TC territory has always been a problem, so I figured I'd throw my hat into the ring and give my own take on a high TC melee weapon a shot.

Technical details

It's a new yaml file with some new sprites, that's all.

Media

  • [ X ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showca
homerunbat.mp4

Breaking changes

Simple Yaml, happy times.

Changelog

🆑

  • add: Added the Home Run Bat for Syndicate operatives. Send your foes flying!

it's metal, knocks you back, and is the only thing secoffs fear
it's ready
mfw rename the locale and don't change it
35 blunt, 15 structural, not 40 and 25
@musicmanvr musicmanvr requested a review from DebugOk as a code owner February 12, 2024 09:09
@github-actions github-actions bot added S: Needs Review Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Feb 12, 2024
Copy link
Contributor

github-actions bot commented Feb 12, 2024

RSI Diff Bot; head commit 1df36be merging into 6d701a7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Weapons/Melee/home_run_bat.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added
wielded-inhand-left Added
wielded-inhand-right Added

Edit: diff updated after 1df36be

@deltanedas
Copy link
Member

goofy as fuck i love it

- type: MeleeThrowOnHit
Speed: 30 # Triple the speed of a gorilla gauntlet, not always a good thing!
Lifetime: 5
unanchorOnHit: true
Copy link
Member

@deltanedas deltanedas Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this unanchor nukes or 500 glimmer probers ⚠️

also yaml typos:
Speed -> speed
Lifetime -> lifetime,
Enabled just remove it since its true by default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses the same properties as the regular gorilla glove, but lemme test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this unanchor nukes or 500 glimmer probers ⚠️

also yaml typos:

Speed -> speed

Lifetime -> lifetime,

Enabled just remove it since its true by default

Congratulations, you just discovered a bug with the gorilla gauntlet. The gauntlet can unanchor glimmer probers at 500, which means the bat can too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prober should prevent unanchor via canceling an event or something on top of the shock thing when using wrench

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prober should prevent unanchor via canceling an event or something on top of the shock thing when using wrench

I mean I can try to code it to where if glimmer is over 500 it physically cannot be unanchored

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I know. But this event isn't getting triggered at all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the event is getting raised on the owner of the MeleeThrowOnHit component, not the thing being hit. Guess I'll just add a new event

Copy link
Member

@deltanedas deltanedas Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or just add another field (if the weapon isnt stored already it might be) for flexibility and raise it on the thing being hit as well, less logic to maintain

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, guess that works too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Feb 18, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still unsure about this, it might be abused heavily. But I'll leave it up to the judgement of the other maintainers

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Mar 8, 2024
@VMSolidus
Copy link
Contributor

I think I would prefer it if this bat wasn't 2.5x as powerful as a wielded baseball bat, even when unwielded. Maybe a little bit stronger would be fine, but not to the point that you could very easily crack open the vault with it. I would like this a bit more of it was something you'd buy for its utility, rather than being arguably one of the best melee weapons in the game. Having knockback on a swing is a very cool utility for sure.

If I ever revisited this later, I actually would want to reflavor it as a "Gorlex Breacher Fist", a power fist sort of weapon that shares its color scheme and design queues with a bloodred hardsuit.

less damage, buy it for utility, it launches people far

Signed-off-by: Firewatch <[email protected]>
Copy link
Member

@deltanedas deltanedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have to fix test too, merging master either now or after upstream pull should do it for the uplink categories

categories:
- UplinkWeapons

#- type: listing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sus


- type: entity
name: home run bat
parent: BaseItem
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why cant this parent bat and remove like 75% of components

@deltanedas deltanedas added S: Derelict Has not been active for a while S: Awaiting Changes Do not merge due to requested changes and removed S: Needs Review labels Apr 22, 2024
@deltanedas
Copy link
Member

@musicmanvr are you still working on this

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Apr 29, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Apr 29, 2024
@deltanedas deltanedas mentioned this pull request Jul 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Awaiting Changes Do not merge due to requested changes S: Derelict Has not been active for a while
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants