Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New centcomm clothes #913

Closed
wants to merge 4 commits into from
Closed

New centcomm clothes #913

wants to merge 4 commits into from

Conversation

noctyrnal
Copy link
Contributor

About the PR

Adds two centcomm clothing items because I uh couldn't think of any more clothes to add rn.

Why / Balance

Drip is essential

Technical details

No major code changes, just two clothes.

Media

  • [ X ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

None

Changelog

  • add: Added two new centcomm clothing items, the long centcomm winter coat and the centcomm turtleneck.

@noctyrnal noctyrnal requested a review from DebugOk as a code owner February 28, 2024 17:55
@github-actions github-actions bot added S: Needs Review Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Feb 28, 2024
@noctyrnal
Copy link
Contributor Author

Guh, forgot to link the images. Here :
1694239c7b2da6bea88a694a36cd6016
d20a452f156dcebfab395f5809778848

Copy link
Contributor

github-actions bot commented Feb 28, 2024

RSI Diff Bot; head commit f2c283e merging into 972ce3f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Clothing/OuterClothing/WinterCoats/cc_large_winter_coat.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpskirt/centcom_turtleneck.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Uniforms/Jumpsuit/centcom_turtleneck.rsi

State Old New Status
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after f2c283e

@ps3moira
Copy link
Contributor

ps3moira commented Feb 29, 2024

I tested it in-game, there's sprite clippings you need to clean up.
image

Check the clothing in-hand sprites as well as the worn-ones to make sure there's no more clipping.

@noctyrnal
Copy link
Contributor Author

guh, I'll fix that today

@noctyrnal noctyrnal closed this Mar 3, 2024
@noctyrnal noctyrnal deleted the clothes branch March 3, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants