Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emergency power unit #918

Closed
wants to merge 4 commits into from
Closed

Emergency power unit #918

wants to merge 4 commits into from

Conversation

DebugOk
Copy link
Contributor

@DebugOk DebugOk commented Feb 29, 2024

About the PR

Adds the Emergency Power Update, part of the "Fucking over salvage part 2" update.

TODO:

  • Get a proper sprite
  • Decide if ~15 minutes of power is enough for the high capacity version

Why / Balance

I'm going to mess up their starting shuttle even more, but I don't want it running out of power too fast

Its literally just an SMES that cant be charged

Media

Content Client_2ka3iLXIYG
Content Client_bGUc3NiXIb

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

@github-actions github-actions bot added the Changes: YML Changes any yml files label Feb 29, 2024
@deltanedas
Copy link
Member

Its literally just an SMES that cant be charged

mining station has this too for reference (unless you stole from there already :trollface:)

@DebugOk
Copy link
Contributor Author

DebugOk commented Feb 29, 2024

Its literally just an SMES that cant be charged

mining station has this too for reference (unless you stole from there already :trollface:)

Its pretty much the same idea :blunt:

@github-actions github-actions bot added the Changes: Sprite Changes any png or json in an rsi label Feb 29, 2024
@DebugOk
Copy link
Contributor Author

DebugOk commented Feb 29, 2024

Should be good to go

@DebugOk DebugOk marked this pull request as ready for review February 29, 2024 22:37
Copy link
Contributor

github-actions bot commented Feb 29, 2024

RSI Diff Bot; head commit 918825b merging into 8967329
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Structures/Power/epu.rsi

State Old New Status
smes-oc0 Added
smes-oc1 Added
smes-oc2 Added
smes-og1 Added
smes-og2 Added
smes-og3 Added
smes-og4 Added
smes-og5 Added
smes-op0 Added
smes-op1 Added
smes-op2 Added
smes-open Added
smes Added
static Added

Edit: diff updated after 918825b

Surely this wont break anything...
Cant wait for space-wizards/space-station-14#24654 to be merged
@github-actions github-actions bot added the Changes: C# Changes any cs files label Feb 29, 2024
@DebugOk
Copy link
Contributor Author

DebugOk commented Feb 29, 2024

Probably gonna self merge tomorrow if its not reviewed before then:tm:

{
"name": "smes"
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

troll indent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real

@DebugOk
Copy link
Contributor Author

DebugOk commented Mar 1, 2024

Gotta figure out how to unfail the test first lol, I wonder if theres a better way to prevent deconstruction

@deltanedas
Copy link
Member

mining station just has it not give you a board, so you can scrap it for steel and lv if you really dont need it

@DebugOk
Copy link
Contributor Author

DebugOk commented Mar 1, 2024

mining station just has it not give you a board, so you can scrap it for steel and lv if you really dont need it

They completely copied the smes prototype, which I wanted to avoid if possible. But it seems like I'll have to if I want it to not give a board

@VMSolidus
Copy link
Contributor

So I had originally been utterly confused why we seemingly want to screw over salvage players. And after playing cargo for a few rounds, I now understand that it's because they genuinely deserve it. This didn't have my approval last night, but it does now. Please do, you now have my support to do everything in your power to screw them over as much as possible.

@DebugOk
Copy link
Contributor Author

DebugOk commented Mar 1, 2024

So I had originally been utterly confused why we seemingly want to screw over salvage players. And after playing cargo for a few rounds, I now understand that it's because they genuinely deserve it. This didn't have my approval last night, but it does now. Please do, you now have my support to do everything in your power to screw them over as much as possible.

Luckily I don't need approval and it would've been merged anyways, salvage will keep getting nerfs until they stop powergaming the shit out of everything they can get their hands on

@VMSolidus
Copy link
Contributor

Good. They deserve it.

@DebugOk DebugOk closed this Mar 7, 2024
@MilonPL MilonPL deleted the EPU branch November 9, 2024 12:59
deltanedas pushed a commit to deltanedas/Delta-v that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants