Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/dei 229 depth averaged rules sigma models #118

Merged
merged 26 commits into from
Aug 5, 2024
Merged

Feature/dei 229 depth averaged rules sigma models #118

merged 26 commits into from
Aug 5, 2024

Conversation

mKlapwijk
Copy link
Contributor

No description provided.

CindyvdVries
CindyvdVries reviewed Jul 30, 2024
View reviewed changes
decoimpact/business/entities/rules/rule_base.py Outdated Show resolved Hide resolved
decoimpact/business/entities/rules/depth_average_rule.py Outdated Show resolved Hide resolved
decoimpact/business/utils/dataset_utils.py Outdated Show resolved Hide resolved
decoimpact/business/utils/dataset_utils.py Outdated Show resolved Hide resolved
decoimpact/business/entities/rule_based_model.py Outdated Show resolved Hide resolved
CindyvdVries
CindyvdVries suggested changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@CindyvdVries CindyvdVries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor things

decoimpact/business/entities/rules/depth_average_rule.py Outdated Show resolved Hide resolved
decoimpact/business/entities/rules/depth_average_rule.py Show resolved Hide resolved
decoimpact/business/entities/rules/depth_average_rule.py Show resolved Hide resolved
decoimpact/business/entities/rules/rule_base.py Outdated Show resolved Hide resolved
decoimpact/data/parsers/parser_depth_average_rule.py Show resolved Hide resolved
tests/business/utils/test_dataset_utils.py Show resolved Hide resolved
CindyvdVries
CindyvdVries approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@CindyvdVries CindyvdVries left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small last things, but otherwise Good to go to test! :)

decoimpact/business/utils/dataset_utils.py Show resolved Hide resolved
decoimpact/business/entities/rules/depth_average_rule.py Outdated Show resolved Hide resolved
decoimpact/business/utils/dataset_utils.py Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mKlapwijk mKlapwijk merged commit 2d32b1f into main Aug 5, 2024
9 checks passed
@mKlapwijk mKlapwijk deleted the feature/DEI-229-depth-averaged-rules-sigma-models branch August 5, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CindyvdVries CindyvdVries CindyvdVries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mKlapwijk @CindyvdVries