Part/feature/part 119 new attempt leeway functionality #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have merged the changes for "leeway" (and ABM for unstructured grids, just a start) as I got it from Frank Kleissen into the code from the main branch. I figured this was necessary to ensure that these changes would not override more recent changes in the main branch that I saw were not transferred when I updated the other branch from main. Long and confusing story.
The leeway option came with a first implementation of ABM for unstructured grids. That is, however, incomplete, so I am keeping the code but making it inaccessible. I turned back a change in oildspfm.f90 that caused a shift in the output series, while Frank could not remember why this was needed. I also turned back the change in the volume correction. This has to be incorporated, but that is better done via PART-194 (as that updates all the references).
Contributor
Author
|
Use this pull request in stead of the old one. |
… of https://github.com/Deltares/Delft3D into part/feature/PART-119-new-attempt-leeway-functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done
Evidence of the work done
<add video/figures if applicable>
Tests
<add testcase numbers if applicable, Issue number>
Documentation
<add description of changes if applicable, Issue number>
Issue link