Skip to content

Conversation

@harmenwierenga
Copy link
Contributor

What was done

  • Converted single line if statements in dflowfm_kernel
  • Added timer info to check function
  • Do not turn on new checker by default because it is too slow (~40 seconds for dflowfm_kernel)
  • Add --converters all and --converters fast (default) options

Evidence of the work done

  • Video/figures
    <add video/figures if applicable>
  • Clear from the issue description
  • Not applicable

Tests

  • Tests updated
    <add testcase numbers if applicable, Issue number>
  • Not applicable

Documentation

  • Documentation updated
    <add description of changes if applicable, Issue number>
  • Not applicable

Issue link UNST-9489

…_fortran_styler_single_line_if_converter

# Conflicts:
#	src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_gui/changetimeparameters.f90
#	src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_kernel/compute/setdt.f90
#	src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_kernel/compute/setdtorg.f90
#	src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_kernel/prepost/pol_to_cellmask.F90
#	src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_kernel/prepost/timestepanalysis.f90
Copy link
Contributor

@rene-deltares rene-deltares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It's a nice idea to distinguish between fast and slow converters.

@harmenwierenga harmenwierenga enabled auto-merge (rebase) December 10, 2025 15:50
auto-merge was automatically disabled December 12, 2025 10:07

Rebase failed

@harmenwierenga harmenwierenga merged commit cd1361f into main Dec 12, 2025
19 checks passed
@harmenwierenga harmenwierenga deleted the all/feature/UNST-9489_fortran_styler_single_line_if_converter branch December 12, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants