Feature/correct mappings #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// @brief Gets the double fill value | ||
| /// @param[out] fillValue The double indicating the fill value | ||
| /// @returns Error code | ||
| UGRID_API int ug_get_double_fill_value(double& fillValue); |
There was a problem hiding this comment.
No need to pass i by ref.
| /// @brief Gets the int fill value | ||
| /// @param[out] fillValue The int indicating the fill value | ||
| /// @returns Error code | ||
| UGRID_API int ug_get_int_fill_value(int& fillValue); |
There was a problem hiding this comment.
No need to pass i by ref.
| @@ -214,9 +213,13 @@ void Mesh2D::put(ugridapi::Mesh2D const& mesh2d) | |||
| } | |||
|
|
|||
| // Edges | |||
| if (auto const it = m_topology_attribute_variables.find("edge_node_connectivity"); mesh2d.edge_node != nullptr && it != m_topology_attribute_variables.end()) | |||
| if (auto const it = m_topology_attribute_variables.find("edge_node_connectivity"); mesh2d.edge_nodes != nullptr && it != m_topology_attribute_variables.end()) | |||
There was a problem hiding this comment.
A general comments about put:
- Are all topology attributes mandatory? Are some optional? If the key of a mandatory attribute is not found in the map, a run time error should be thrown.
- Can't the if statements be replaced by a generic function?
tests/api/ApiTests.cpp
Outdated
There was a problem hiding this comment.
Should use vectors instead of unique_ptrs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.