Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements to the plot_basemaps method #120

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Some improvements to the plot_basemaps method #120

merged 3 commits into from
Nov 8, 2023

Conversation

DirkEilander
Copy link
Contributor

@DirkEilander DirkEilander commented Aug 9, 2023 •
edited
Loading

This PR

  • adds more background maps support by contextily
  • makes it possible to plot other than "grid" variables on the basemap, e.g. the hmax flood map
  • fixes a bug that ignores the write_gis argument when writing forcing bnd and src files

@roeldegoede
Copy link
Collaborator

Is this ready for review, or are there more improvements that you want to add? Maybe we can try to tackle #123 in this PR as well?

@DirkEilander DirkEilander marked this pull request as ready for review October 23, 2023 14:36
@DirkEilander
Copy link
Contributor Author

DirkEilander commented Oct 23, 2023 •
edited
Loading

Is this ready for review, or are there more improvements that you want to add? Maybe we can try to tackle #123 in this PR as well?

I don't have an easy dataset to test that issue with available here. I suggest to fix that separately. I'll add a comment in that issue on a possible solution direction.

roeldegoede
roeldegoede approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@roeldegoede roeldegoede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and very clear explanations. Everything seems to work on my side as well, so ready for merging!

@DirkEilander DirkEilander merged commit cab59fb into main Nov 8, 2023
5 checks passed
@DirkEilander DirkEilander deleted the plot_bmap branch November 8, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roeldegoede roeldegoede roeldegoede approved these changes

Assignees

@DirkEilander DirkEilander

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DirkEilander @roeldegoede