-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start with Ribamod docs #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and complete documentation I think. I have some small comments and additions.
both, and writes: | ||
|
||
* the Ribasim model | ||
* the MODFLOW 6 simulation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also use MODFLOW 6 model for consistency?
|
||
As `primod` is a Python package, both models must be represented in Python: | ||
|
||
* The MODFLOW 6 simulation is represented by the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here relate the model to the simulation object in imod-python?
Basin / Static or Basin / Time tables. | ||
* Similarly, not every River and Drainage boundary needs to be linked with | ||
Ribasim. Boundaries outside of any basin polygon will simply use the regular | ||
file input. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wat about partially linked basins? There we overrule the Ribasim input, but only partly replace it with River and Drainage fluxes from MODFLOW 6 right?
### Active coupling | ||
|
||
The derivation of active coupling exchanges proceeds largely the same, but also | ||
locates the nearest subgrid elements: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add: This is needed for the exchange of stages defined at these elements.
This ensures that Ribasim does not overwrite the exchange flows while running | ||
coupled with MODFLOW 6. | ||
|
||
Conceptually, it also means that when a basin is coupled, it should generally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe move this up at the location of my comment on partially linked basins?
infiltration will proceed even when the Ribasim basin is empty. | ||
|
||
The second is a more pressing problem, as it will results in a discrepancy | ||
between the water balances of both models. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a comment on how to deal with the second point? The bottom of RIV elements within a basin should never be lower than the lowest waterlevel of the subgrid elements right? This is maybe problematic for the 'downstream' RIV elements?
## MODFLOW6 | ||
|
||
No specific files are required. The MODFLOW6 model must contain River or | ||
Drainage packages which represent the surface water. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add again: location and bottom elevation need to be consistent with the Ribasim model
This makes a start with the Ribamod imod coupler docs.
I've added a technical section inspired by the MetaMod one. I've also specifically added a section on pre-processing, explicitly mentioning primod.
As mentioned in #41, this is good addition for the other drivers as well.