Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rhs argument to enable "poisson interpolation" in laplace_interpo… #1106

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Huite
Copy link
Contributor

@Huite Huite commented Jul 11, 2024

This would allow us to do fancy downscaling, basically getting rid of respighi: instead of MODFLOW, we can directly call this function.

@Huite Huite marked this pull request as draft July 11, 2024 14:16
@Huite Huite requested review from JoerivanEngelen and removed request for JoerivanEngelen July 11, 2024 14:19
@JoerivanEngelen
Copy link
Contributor

Some screenshots for context: The poisson interpolation allows interpolating ditches with recharge.

This would looks something like this for ditches:
image
Where purple line is the ditch level (boundary condition), blue line is the laplacian interpolation, and red line the poisson interpolation. This is an example for negative recharge AFAIK (was still work in progress and the sign got swapped accidentily, but it was the best screenshot I have to explain the context somewhat).

After fixing the sign errors this turned into:
image

Copy link

sonarcloud bot commented Jul 15, 2024

@Huite
Copy link
Contributor Author

Huite commented Jul 15, 2024

After some reflection: the respighi scaling method requires us to use "weak" boundaries as well (e.g. RIV or GHB).

With only hard boundaries, if you downscale at 25.0 m, the value at 25.0 m gets burned into the grid directly. This means that if the ditch distance is <50 m or so, you will only get the boundary conditions (like ditch stages). This would mean that for e.g. the peaty areas of South-Holland, the scaling essentially fails.

It's relatively easy to add a robin boundary (a GHB) as optional arguments for the system of equations.

This allows the interpolated head to deviate somewhat from the provided robin values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants