Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for ribasim #79

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Fixes for ribasim #79

merged 1 commit into from
Mar 26, 2024

Conversation

Huite
Copy link
Contributor

@Huite Huite commented Mar 26, 2024

Make sure arrow variables are refreshed when switching layers

Support for node_id != basin feature id

Support for node_id != basin feature id
@Huite Huite requested review from visr and JoerivanEngelen March 26, 2024 09:49
@visr
Copy link
Member

visr commented Mar 26, 2024

In #69 I added this to filter out the non-float columns from the drop-down:

variables = sample_df.select_dtypes(include=["float"]).columns.tolist()

Only "edge_id" is still there for some reason. Do you know why, and can we remove it easily?

image

@Huite
Copy link
Contributor Author

Huite commented Mar 26, 2024

Same reason as this: Deltares/Ribasim#1320

@JoerivanEngelen JoerivanEngelen merged commit a7c8e02 into main Mar 26, 2024
2 checks passed
@visr visr deleted the ribasim-arrow-fixes branch March 26, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants