Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create RibaMetaMod as a copy of RibaMod #202

Merged
merged 8 commits into from
Nov 13, 2023
Merged

Create RibaMetaMod as a copy of RibaMod #202

merged 8 commits into from
Nov 13, 2023

Conversation

HendrikKok
Copy link
Contributor

Initial copy of RibaMod-class

@HendrikKok HendrikKok marked this pull request as ready for review November 13, 2023 13:14
@HendrikKok
Copy link
Contributor Author

Initial work on RibaMetaMod driver:

1 - Copy of Ribamod driver
2 - Copy of Ribamod tests
3 - Copy of Ribamod in primod

SonarCloud fails on code duplication: as expected since it’s a copy of Ribamod
Mypy fails on metamod: inherited this from main, not a result of work in this branch.

@Hofer-Julian Hofer-Julian merged commit 2b1f8fa into main Nov 13, 2023
6 of 8 checks passed
@Hofer-Julian Hofer-Julian deleted the add_metamod branch November 13, 2023 14:59
Copy link

sonarcloud bot commented Nov 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
64.1% 64.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants