-
Notifications
You must be signed in to change notification settings - Fork 7
Pymoca 0.11 #1660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Pymoca 0.11 #1660
Conversation
03367be to
240ff5d
Compare
|
I would be very happy to get rid of the 0.9.x maintenance branch on the Pymoca side! I do expect Pymoca to significantly improve and make API-breaking changes over the next couple of months (e.g. in a version 0.12.x), so pinning to 0.11.x like done in this PR is the correct approach IMO. |
|
Should this branch be rebased on master? |
|
|
Rebased on new master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the project to use pymoca 0.11 by introducing a curated standard library replacement and fixes a minor Modelica syntax issue in a test model.
- Add missing semicolon in Modelica test model to correct parsing
- Bump
pymocadependency to 0.11.* and addrtc-tools-standard-librarypackage
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/simulation/data/infeasible_initial_value/model_with_sym_ystart.mo | Add missing semicolon to Real x declaration |
| setup.py | Pin pymoca to 0.11.*, add rtc-tools-standard-library dependency |
Comments suppressed due to low confidence (1)
tests/simulation/data/infeasible_initial_value/model_with_sym_ystart.mo:3
- Missing semicolon will cause a Modelica parse error; ensure all variable declarations end with ';'.
Real x(start=x0-10);
|
Thank you for this pull request, @jgillis! Since we will probably be moving to the LF soon, it's best to wait until the repo is migrated to merge these changes. In the coming days, we will be able to provide a likely timeline for when this will happen. |


The project seems seems to be stuck on pymoca
0.9.*.Since pymoca 0.10.0,
ModelicaandSIare no longer listed as builtin type ( pymoca/pymoca@cf6d6a3 ).On the other hand, pymoca cannot yet successfully parse the Modelica Standard Library.
My proposal is to introduce rtc-tools-standard-library, a manually-curated minimal standard library replacement, exclusively tailored to rtc-tools.
However, this approach may break user code when they are using standard library constructs that are untested in the rtc-tools repo.