[CI verify] uniffi 0.32 toml align + MSRV 1.88 - #1
Closed
DenisovAV wants to merge 2 commits into
Closed
Conversation
uniffi 0.32's bindgen trait signatures use toml 1.x's `Value`, but the `toml = ">=0.8, <=0.9"` constraint resolved a different `toml` crate, producing E0053 "incompatible type for trait" on `new_config`/`get_toml` in src/gen/mod.rs. This broke the downstream binding tests and the main Test Suite compile. Pinning `toml = "1"` aligns the type with 0.32. The 0.32 dependency tree requires a newer Rust: cargo_metadata pulls cargo-platform 0.3.3 (rustc >= 1.91) and uniffi 0.32 pulls askama 0.16 (rustc >= 1.88). Raise the declared rust-version and the nix msrv shell from 1.85 to 1.91 to match the real floor.
Match the crate rust-version raised for the uniffi 0.32 upgrade; the resolved dependency tree (cargo-platform 0.3.3) requires rustc 1.91.
DenisovAV
force-pushed
the
support-uniffi-0.32
branch
from
August 14, 2026 06:06
c1f364e to
9583902
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway internal PR to run CI on our own fork (upstream Uniffi-Dart#149 runs are gated on maintainer approval). Verifies the toml=1 E0053 fix and the 1.88 MSRV matrix go green. Do not merge; will be closed after CI.