[CI] #149 ForeignBytes review fixes - #4
Closed
DenisovAV wants to merge 1 commit into
Closed
Conversation
…gth guard Review follow-up on the borrowed-bytes lowering: - Empty `Uint8List`: pass `(null, 0)` instead of `calloc<Uint8>(0)`. A zero-size `calloc` is platform-variable — some allocators return null, which makes package:ffi's `calloc.allocate` throw — while Rust's `ForeignBytes::as_slice` reads `(null, 0)` as `&[]`. Mirrors the Kotlin/Python ByRef converters, which special-case zero length to a null pointer for exactly this reason. - Guard against silent truncation: `ForeignBytes.len` is an `Int32`, so a `Uint8List` larger than `0x7fffffff` would wrap to a bogus (or negative) length and make Rust read the wrong slice or panic across the FFI boundary. Throw an `ArgumentError` instead. Also reword the oracle.rs routing comment so "borrowed" (the Rust-side borrow) isn't read as "zero-copy" on the Dart side, which still copies into native memory (a GC `Uint8List` has no stable address).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork CI for Uniffi-Dart#149 head 992c32e after review fixes (empty-slice null ptr, Int32 guard, comment). Not for merge.