Implement type system #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polyntsov
force-pushed
the
type_system
branch
2 times, most recently
from
e75ffc5 to
c29d824
Compare
Mstrutov
requested changes
Mar 22, 2022
Made the RelationData abstract class template. So it can be used as a base class for other classes that represent column layout data with differenent column types.
It is usefull to be able to parse the same table more than once
Mstrutov
approved these changes
Mar 25, 2022
| test(11.4, 3.14); | ||
| test(-102, 11); | ||
| test(-123, 123); | ||
| test(-21, -7); |
There was a problem hiding this comment.
Думаю, в тестах нужно ещё фиксировать, что происходит, если поделить на 0.
There was a problem hiding this comment.
По стандарту ub, на практике, думаю, происходит sigfpe (на линуксе). Кажется, ни то, ни то нельзя отловить в тестах.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements classes for types and classes describing typed columns, relational typed data. Knowing the type of data in a column is necessary to collect statistics and identify possible typos in typo mining workflow.