Skip to content

fix list.__add__ #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KotlinIsland wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix list.__add__ #1490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/pyright-internal/src/tests/typeEvaluator8.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ test('CodeFlow7', () => {
test('CodeFlow8', () => {
const analysisResults = TestUtils.typeAnalyzeSampleFiles(['codeFlow8.py']);

TestUtils.validateResults(analysisResults, 0);
TestUtils.validateResults(analysisResults, 2); // https://github.com/DetachHead/basedpyright/issues/1491
});

test('CodeFlow9', () => {
Expand Down
6 changes: 1 addition & 5 deletions packages/pyright-internal/typeshed-fallback/stdlib/builtins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,11 +1121,7 @@ class list(MutableSequence[_T]):
@overload
def __setitem__(self, key: slice, value: Iterable[_T], /) -> None: ...
def __delitem__(self, key: SupportsIndex | slice, /) -> None: ...
# Overloading looks unnecessary, but is needed to work around complex mypy problems
@overload
def __add__(self, value: list[_T], /) -> list[_T]: ...
@overload
def __add__(self, value: list[_S], /) -> list[_S | _T]: ...
def __add__[Other, Expected](self, value: list[Other], /) -> list[Expected | _T | Other]: ...
def __iadd__(self, value: Iterable[_T], /) -> Self: ... # type: ignore[misc]
def __mul__(self, value: SupportsIndex, /) -> list[_T]: ...
def __rmul__(self, value: SupportsIndex, /) -> list[_T]: ...
Expand Down
Loading