Skip to content

fix skip_replace hack docs #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DetachHead merged 1 commit into from
Dec 25, 2025
+2 −2
Merged

fix skip_replace hack docs #1686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/benefits-over-pyright/dataclass-transform.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ to allow type checkers to add their own little hacks on top of the standard ones
Pyright (and basedpyright) assumes that classes produced by a dataclass transform
define a `__replace__` method, as long as the class is not marked with `init=False` and does
not define a custom `__init__` method.
However, `typing.dataclass_transform` doesn't require that the `__replace__` method is defined.
You may want a `dataclass`-like decorator or metaclass that does not support `__replace__` at all.

In addition, `__replace__` messes with the variance inference of frozen dataclasses (see
In particular, `__replace__` messes with the variance inference of frozen dataclasses (see
[this discourse thread](https://discuss.python.org/t/make-replace-stop-interfering-with-variance-inference/96092)
for details). Here's a recipe you can use to work around this:

Expand Down