Add baselineMode extension setting for workspace for auto | discard

[andyscho]

Add a baselineMode extension setting at the workspace level for auto | discard. Not including lock or other settings for now since the behavior it would have in the extension is less clear to me, and --baselinemode is referenced as experimental in the cli documentation. So it seems fine to be less aggressive with exposing modes to users here.

Default behaviors are unchanged (still defaults to auto).

This satisfies the first part of the proposal in #1692.

Users using discard in the extension may want to include a pre-commit hook running basedpyright with a different baselinemode (i.e. auto or no --baselinemode/--writebaseline flag) to get rid of baslined errors that are no longer relevant.

This intentionally does not address #1524 yet, though there's no reason why it can't be included later.

[DetachHead]

thanks for the contribution!

[DetachHead]

Users using discard in the extension may want to include a pre-commit hook running basedpyright with a different baselinemode (i.e. auto or no --baselinemode/--writebaseline flag) to get rid of baslined errors that are no longer relevant.

i think this is something we can just document as a tip for users who want this behavior, rather than something integrated into the language server (i'm not sure how that would even work)

[andyscho]

i think this is something we can just document as a tip for users who want this behavior, rather than something integrated into the language server (i'm not sure how that would even work)

i think this is something we can just document as a tip for users who want this behavior, rather than something integrated into the language server (i'm not sure how that would even work)

Agreed. It was more of a suggestion for users. I made a change to put the suggestion into the documentation (plus some other changes), let me know what you think.

[github-actions]

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅