Skip to content

fix(install): accept flat Windows release archives without payload wrapper (#1257) - #1259

Open
skbs-eng wants to merge 1 commit into
DeusData:mainfrom
skbs-eng:fix/install-ps1-archive-layout
Open

fix(install): accept flat Windows release archives without payload wrapper (#1257)#1259
skbs-eng wants to merge 1 commit into
DeusData:mainfrom
skbs-eng:fix/install-ps1-archive-layout

Conversation

@skbs-eng

Copy link
Copy Markdown

Fixes #1257

Problem

install.ps1's archive namespace check strictly required codebase-memory-mcp.payload.exe to exist as a separate entry in the release zip. In release builds where codebase-memory-mcp.exe is packaged as a flat standalone binary without a separate *.payload.exe entry (such as the v0.9.0 windows-arm64 and windows-amd64 UI archives), install.ps1 aborted with:
\�rror: unsafe or incomplete release archive: archive must contain exactly one codebase-memory-mcp.payload.exe\

Fix

  • Updated install.ps1 archive layout validation to require codebase-memory-mcp.exe, LICENSE, install.ps1, and THIRD_PARTY_NOTICES.md, while allowing codebase-memory-mcp.payload.exe to be optional (0 or 1 instance).
  • If codebase-memory-mcp.payload.exe is missing from the extracted archive, install.ps1 stage-copies codebase-memory-mcp.exe to codebase-memory-mcp.payload.exe in the temporary directory prior to executing the launcher installation.
  • Updated ests/test_windows_bundle_contract.sh static contract checks to reflect the updated archive bounds.

Validation

  • Verified with python contract test script (\ est_windows_bundle_contract.sh).
  • Tested \install.ps1\ archive extraction against both 4-file (flat layout) and 5-file (pair layout) zip archives.

@skbs-eng
skbs-eng requested a review from DeusData as a code owner July 25, 2026 08:23
@skbs-eng
skbs-eng force-pushed the fix/install-ps1-archive-layout branch from 16a1ea3 to 683e97f Compare July 27, 2026 13:28
…p.payload.exe (DeusData#1257)

Signed-off-by: S <5842097+skbs-eng@users.noreply.github.com>
@skbs-eng
skbs-eng force-pushed the fix/install-ps1-archive-layout branch from 683e97f to 0c901ef Compare July 27, 2026 13:31
@DeusData DeusData added bug Something isn't working duplicate This issue or pull request already exists editor/integration Editor compatibility and CLI integration ux/behavior Display bugs, docs, adoption UX labels Jul 28, 2026
@DeusData DeusData added this to the 0.9.1-rc milestone Jul 28, 2026
@DeusData DeusData added windows Windows-specific issues priority/high Needs near-term maintainer attention; high-impact bug, regression, safety issue, or release blocker. labels Jul 28, 2026
@DeusData

DeusData commented Jul 28, 2026

Copy link
Copy Markdown
Owner

Thank you for the contribution and for validating both Windows archive layouts. This is now triaged as a high-priority Windows installation bug for 0.9.1-rc. Current main already contains an overlapping fix for #1257, so review will determine whether this branch still contains any distinct work. Our community PR queue is currently quite full, so it may take a little time before we can complete that review. We are doing our best to support community contributions and will return with code-grounded feedback as capacity opens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working duplicate This issue or pull request already exists editor/integration Editor compatibility and CLI integration priority/high Needs near-term maintainer attention; high-impact bug, regression, safety issue, or release blocker. ux/behavior Display bugs, docs, adoption UX windows Windows-specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install.ps1 rejects v0.9.0 windows-arm64 UI archive: 'archive must contain exactly one codebase-memory-mcp.payload.exe'

2 participants