fix(contract): 0h VM-soak needle onto the canonical soak entry (dry-run test-wave red) - #1281
Merged
Conversation
… entry The venue unification moved the VM soak sequence and its completion guard into scripts/soak-legs.sh; the smoke-fixture contract still pinned the old direct soak-test.sh call in vm-run-tests.sh, failing Step 0h — and with it every test leg on every venue of dry run 30224804737 (the test wave's 20 reds share this one cause). Masked until now: the contract chain runs sequentially and Step 0e failed first on the pre-fix tree, so 0h was never reached; post-fix verification used --suites mode, which skips the chain. All contract steps 0a-0j now verified green standalone in bulk. Invariant preserved, anchor moved: the VM wrapper must route --soak through the canonical entry under its protected temp root, and the canonical entry must completion-guard every leg on the soak summary (grep for '=== soak-test: PASSED ===' lives in soak-legs.sh:101). Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix-forward for dry run 30224804737: all 20 test-wave reds share one cause — Step 0h still pinned the pre-unification direct soak-test.sh call. Chain-masking (0e failed first; --suites skips contracts) hid it until the 0e fix landed. All contract steps 0a–0j now verified green standalone. Invariant kept: canonical-entry routing + completion guard, anchors moved to where the behavior lives.