ci: revert runner-side Defender gating (RTP policy-locked off on hosted images) - #1282
Merged
Conversation
…ting Dry run 30225685743 failed at the ensure-defender step on every Windows job: the hosted images policy-lock real-time protection OFF (WinDefend starts, Set-MpPreference accepts, RTP stays off — untamperable from the job). Revert to the pre-gate runner behavior: no ensure-defender step in runner jobs, the release Defender scan is on-demand and fail-soft again. The local VM preflight KEEPS the fail-closed Defender-ON gate (same canonical script) — AV-interaction coverage is a deliberate local superset where the platform allows it. The venue-parity contract now enforces the INVERSE for runners (ensure-defender must not gate hosted jobs) and still requires the VM preflight gate; VM README documents the verified posture delta. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
Local soak legs write soak-results*/ into the worktree; a bulk add swept one run's logs into the previous commit. Remove them from tracking and ignore the output directories (CI uploads them as artifacts; they are never repository content). Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
…load The manifest content (leg, slice, list hash) is fully determined at slicing time, so write it up front: a red run's manifest is exactly as load-bearing for the cross-shard union proof as a green one's. With that, a missing manifest at upload time can only mean the job died before the harness started (contract step / build failure) — that failure is already the job's red, so the upload warns instead of stacking a second error on top (the recurring 'No files were found with the provided path: build/c/test-logs/shard-manifest.txt' annotation). The shard-completeness job still gates the union. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix-forward for dry run 30225685743: every Windows job died at ensure-defender — hosted images policy-lock RTP off (verified in-run: service starts, preference accepted, RTP stays off). Runner jobs revert to the pre-gate shape (on-demand fail-soft release scan); the VM keeps the fail-closed Defender-ON preflight (deliberate local superset). Contract now enforces the inverse on runner workflows and still requires the VM gate. Pre-authorized fallback.