Local-ladder green: BSD mktemp soak fix (CI-mac-gating) + 0h port-poll tolerance + Alpine curl - #1285
Merged
Merged
Conversation
BSD mktemp substitutes only TRAILING X's, so the template
cbm-soak-leg-XXXXXX.log creates a near-literal file on macOS and the
second leg of the same job collides with the first leg's leftover
('File exists'). First runs mask it — which is why the quick leg
passed and query-leak failed locally, and why CI's macos soak jobs
(BSD mktemp, two legs per job) would fail the same way.
Drop the suffix; the path is only a log handle.
Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
…lf-test On Windows the fixture server's atomic port publish (os.replace) — or a first-touch AV scan of the fresh file, with Defender ACTIVE on the VM — briefly denies the read: is_file() is true, read_text() raises PermissionError, and the poll loop crashed the whole contract with a bare traceback (observed on the VM once the 0e/0h needle fixes let the chain reach this self-test at all). Treat an unreadable-yet port file as not-ready and keep polling inside the existing deadline. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
The unified smoke-local.sh readiness-polls the fixture server with curl; the Alpine image never had it, so every poll iteration failed command-not-found and the portable smoke leg reported 'fixture server did not serve' with a perfectly healthy server. Local-only image (CI portable smokes run on ubuntu runners, curl preinstalled). Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three harness fixes from driving the full local ladder to green on merged main. The mktemp one is REMOTE-gating: CI's macos soak jobs run two legs per job on BSD mktemp and collide on the near-literal leftover exactly like the local repro. The other two are local-venue-only (Windows/Defender port-publish race in the 0h self-test; curl missing from the Alpine smoke image). Local ladder is fully green with these: mac 6621/0 + TSan + smoke + artifact + soak×2 · linux test/perf/TSan/smoke/portable/artifact/glibc-floor/soak×2 · windows test-par 6681/0 solo + guards + smoke-install + smoke-artifact + soak×2.