fix(build): force LF line endings for shell scripts - #1314
Open
mlandolfi90 wants to merge 1 commit into
Open
Conversation
With git's Windows default (core.autocrlf=true) every .sh checks out with CRLF, and the Docker cross-build fails at clean-c: bash cannot source scripts/path-safety.sh ($'\r': command not found). Declaring *.sh text eol=lf keeps checkouts LF on every platform regardless of local git config. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: mlandolfi90 <mlandolfi90@users.noreply.github.com>
DeusData
added
bug
DeusData
added
ux/behavior
Owner
|
Thank you for the contribution and for reporting the Windows checkout failure from a fresh build. This is now triaged as a high-priority Windows build bug for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, git's default
core.autocrlf=truechecks out every.shwith CRLF endings. The Docker cross-build then fails atclean-c: bash cannot sourcescripts/path-safety.sh($'\r': command not found), and the same applies to every script underscripts/andtests/.Declaring
*.sh text eol=lfin.gitattributeskeeps checkouts LF on all platforms regardless of local git config. One-line fix, no renormalization needed — the index already stores LF.Hit today on a fresh Windows clone while building from
main.🤖 Generated with Claude Code