Skip to content

Commit

Permalink
SQL and PHP cases
Browse files Browse the repository at this point in the history 
PHP true,false,null in lowercase
SQL keywords uppercase
  • Loading branch information
Alexandra Nantel committed Oct 20, 2017
1 parent 37f96e1 commit 367e46d
Showing 1 changed file with 21 additions and 20 deletions.
41 changes: 21 additions & 20 deletions fields/field.link_preview.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public function allowDatasourceParamOutput(){
*/
public function checkPostFieldData($data, &$message, $entry_id = null){
// Always valid!
$message = NULL;
$message = null;
return self::__OK__;
}

Expand Down Expand Up @@ -141,12 +141,12 @@ public function setFromPOST(Array $settings = array()) {
*/
public function commit() {
// if the default implementation works...
if(!parent::commit()) return FALSE;
if(!parent::commit()) return false;

$id = $this->get('id');

// exit if there is no id
if($id == false) return FALSE;
if($id == false) return false;

// declare an array contains the field's settings
$settings = array();
Expand All @@ -170,7 +170,7 @@ public function commit() {
return FieldManager::saveSettings($id, $settings);
}

public function entryDataCleanup($entry_id, $data=NULL){
public function entryDataCleanup($entry_id, $data = null){
// do nothing since we do not have any data table
}

Expand All @@ -182,7 +182,7 @@ public function entryDataCleanup($entry_id, $data=NULL){
* @param $wrapper
* @param $data
*/
public function appendFormattedElement(XMLElement &$wrapper, $data, $encode = false, $mode = NULL, $entry_id = NULL) {
public function appendFormattedElement(XMLElement &$wrapper, $data, $encode = false, $mode = null, $entry_id = null) {
// NOTHING
}

Expand All @@ -201,10 +201,11 @@ public function appendFormattedElement(XMLElement &$wrapper, $data, $encode = fa
* @param string $fieldnamePrefix
* @param string $fieldnamePostfix
*/
public function displayPublishPanel(XMLElement &$wrapper, $data = NULL, $flagWithError = NULL, $fieldnamePrefix = NULL, $fieldnamePostfix = NULL, $entry_id = NULL) {
public function displayPublishPanel(XMLElement &$wrapper, $data = null, $flagWithError = null, $fieldnamePrefix = null, $fieldnamePostfix = null, $entry_id = null) {
if (!$entry_id && $this->get('display_new') === 'no') {
return;
}

$sectionId = $this->get('parent_section');
$format = $this->get('format');
$url = $this->applyFormat($entry_id, $format, $sectionId);
Expand Down Expand Up @@ -281,7 +282,7 @@ private function applyFormat($entryId, $format, $sectionId) {
$qualifier = '';

// check variable for namespace and qualifier
if (strpos($variable, 'system:') !== FALSE) {
if (strpos($variable, 'system:') !== false) {
// case '$system:variable'
if (substr_count($variable, ':') == 1) {
$value = $sysData[$variable];
Expand All @@ -299,7 +300,7 @@ private function applyFormat($entryId, $format, $sectionId) {
}
}
// case '$variable:qualifier'
} else if (strpos($variable, ':') !== FALSE) {
} else if (strpos($variable, ':') !== false) {
$fragments = preg_split('[:]', $variable);
$qualifier = $fragments[1];
$variable = $fragments[0];
Expand Down Expand Up @@ -375,12 +376,12 @@ public static function getFieldValue($field, $fieldValues, $qualifier) {
* @param XMLElement $wrapper
* @param array $errors
*/
public function displaySettingsPanel(XMLElement &$wrapper, $errors=NULL){
public function displaySettingsPanel(XMLElement &$wrapper, $errors = null){
/* first line, label and such */
parent::displaySettingsPanel($wrapper, $errors);

/* new line */
$opts_wrap = new XMLElement('div', NULL, array('class' => 'two columns'));
$opts_wrap = new XMLElement('div', null, array('class' => 'two columns'));

/* url format */
$url_title = new XMLElement('label', __('URL Format <i>Use {$param} syntax</i>'), array('class' => 'column link_preview_url'));
Expand All @@ -393,7 +394,7 @@ public function displaySettingsPanel(XMLElement &$wrapper, $errors=NULL){
$opts_wrap->appendChild($anchor_title);

/* new line, check boxes */
$chk_wrap = new XMLElement('div', NULL, array('class' => 'three columns'));
$chk_wrap = new XMLElement('div', null, array('class' => 'three columns'));
$this->appendShowColumnCheckbox($chk_wrap);
$this->appendDisplayUrlCheckbox($chk_wrap);
$this->appendDisplayNewCheckbox($chk_wrap);
Expand All @@ -408,8 +409,8 @@ public function displaySettingsPanel(XMLElement &$wrapper, $errors=NULL){
* @param XMLElement $wrapper
*/
private function appendDisplayUrlCheckbox(&$wrapper) {
$label = new XMLElement('label', NULL, array('class' => 'column'));
$chk = new XMLElement('input', NULL, array('name' => 'fields['.$this->get('sortorder').'][display_url]', 'type' => 'checkbox', 'value' => 'yes'));
$label = new XMLElement('label', null, array('class' => 'column'));
$chk = new XMLElement('input', null, array('name' => 'fields['.$this->get('sortorder').'][display_url]', 'type' => 'checkbox', 'value' => 'yes'));

$label->appendChild($chk);
$label->setValue(__('Display URL in entries table (Instead of anchor label)'), false);
Expand Down Expand Up @@ -441,10 +442,10 @@ private function appendDisplayNewCheckbox(&$wrapper) {
}


private function createInput($text, $key, $errors=NULL) {
private function createInput($text, $key, $errors = null) {
$order = $this->get('sortorder');
$lbl = new XMLElement('label', __($text), array('class' => 'column'));
$input = new XMLElement('input', NULL, array(
$input = new XMLElement('input', null, array(
'type' => 'text',
'value' => $this->get($key),
'name' => "fields[$order][$key]"
Expand Down Expand Up @@ -529,10 +530,10 @@ public static function createFieldTable() {

return Symphony::Database()->query("
CREATE TABLE IF NOT EXISTS `$tbl` (
`id` int(11) unsigned NOT NULL auto_increment,
`field_id` int(11) unsigned NOT NULL,
`format` varchar(255) NULL,
`anchor_label` varchar(255) NULL,
`id` INT(11) UNSIGNED NOT NULL AUTO_INCREMENT,
`field_id` INT(11) UNSIGNED NOT NULL,
`format` VARCHAR(255) NULL,
`anchor_label` VARCHAR(255) NULL,
`display_url` ENUM('yes', 'no') DEFAULT 'no',
`display_new` ENUM('yes', 'no') DEFAULT 'yes',
PRIMARY KEY (`id`),
Expand All @@ -550,7 +551,7 @@ public static function updateFieldTable_AnchorLabel() {

return Symphony::Database()->query("
ALTER TABLE `$tbl`
ADD COLUMN `anchor_label` varchar(255) NULL
ADD COLUMN `anchor_label` VARCHAR(255) NULL
");
}

Expand Down

0 comments on commit 367e46d

Please sign in to comment.