Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete plus saving handle and ID to DB #3

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Autocomplete plus saving handle and ID to DB #3

wants to merge 12 commits into from

Conversation

andrewminton
Copy link

Some thoughts on how to grab/populate and save handle and Id's back to database.

You may want to clean up/alter the JS. Not our strong point.

@nitriques
Copy link
Member

Thanks! I'll check this ASAP!

@nitriques
Copy link
Member

Ok. I've reviewed this thing 3 times now. Sorry, but I can't accept it.

  1. It's too hard for me to track all those changes
  2. There is no upgrade path (that's important for me)
  3. Sorting in is is a no go. This should be done by the data source (server side ordered json)

But, I really like it and there's like 80% of the code that's good.

Could we proceide like this:

[ ] Start a new branch.
[ ] Increment the minor version.
[ ] Update the table there with the new multiple value setting (see my oembed field on how I did it https://github.com/Solutions-Nitriques/oembed_field/blob/master/extension.driver.php#L129
[ ] Call the update function in the insert function. (again, see oembed)
[ ] Create a working version, without the plugin
[ ] Add yourself as an author in the meta xml file
[ ] Send a PR.

I'll try to implement the "saving" the text feature after that.

When that's done, I'll ask (please!) you to do a 1.2 version with the plugin...

That way it will be easier for me (or us!) to test, release, maintain, track changes

Does it sounds good ?

@andrewminton
Copy link
Author

Totally understand.

Will get to this for you as soon as possible :)

@nitriques
Copy link
Member

THANK YOU VERY MUCH !!!

@andrewminton
Copy link
Author

I will get around to starting work on this next week. Finally freeing up time in work ;)

@nitriques
Copy link
Member

Awesome! No rush!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants