-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HtmlEditor: Markdown Support demo #28364
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksercs
reviewed
Nov 15, 2024
9edca19
to
1fa653b
Compare
5e25b2c
to
7ade14a
Compare
ksercs
reviewed
Nov 19, 2024
7ade14a
to
eb88e7e
Compare
apps/demos/Demos/HtmlEditor/MarkdownSupport/Angular/app/app.component.css
Outdated
Show resolved
Hide resolved
308b7d9
to
49a8046
Compare
EugeniyKiyashko
previously approved these changes
Nov 22, 2024
ksercs
previously approved these changes
Nov 22, 2024
inputAttr: { | ||
'aria-label': 'Header', | ||
}, | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[minor, no need to change]
I think it's better to place it in data.ts
together with a markup
EugeniyKiyashko
previously approved these changes
Nov 22, 2024
5ce6678
Squashed commits: [5154bfd] fix(server.js): Fix css path
5ce6678
to
fbb9c47
Compare
ksercs
approved these changes
Nov 22, 2024
EugeniyKiyashko
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.