DataGrid - AI Assistant: command execution e2e tests#33804
Merged
Alyar666 merged 14 commits intoJun 12, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new TestCafe e2e suite validating DataGrid AI Assistant command execution across common scenarios and grid-state edge cases, plus the necessary TestCafe page-object (POM) accessors and shared helpers to support the tests.
Changes:
- Added
commands.functional.tsTestCafe coverage for single/multi-command execution, stacked operations, and empty/single-row/large/single-column/all-hidden/already-in-target-state grids. - Introduced shared AI Assistant TestCafe helpers (
testHelpers.ts) for consistent page setup and client-side utilities. - Extended
devextreme-testcafe-modelsDataGrid/AI Assistant chat models with new accessors to query AI chat state and interact with AI Assistant UI.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/testcafe-models/dataGrid/index.ts | Adds DataGrid POM helpers for AI Assistant button focus and reading DataSource sort parameters. |
| packages/testcafe-models/dataGrid/aiAssistantChat.ts | Expands AI Assistant chat POM with input/suggestions/message accessors and abort-confirm dialog selectors. |
| packages/testcafe-models/chat.ts | Adds a reusable getMessageBubbles() accessor and refactors getMessage() to use it. |
| e2e/testcafe-devextreme/tests/dataGrid/common/aiAssistant/testHelpers.ts | Adds shared constants and client-side helpers for the AI Assistant e2e tests. |
| e2e/testcafe-devextreme/tests/dataGrid/common/aiAssistant/commands.functional.ts | New functional e2e suite covering AI Assistant command execution and edge-case grid states. |
Alyar666
force-pushed
the
ai_assistant_e2e_commands_26_1
branch
from
bdf146c to
1b14a9f
Compare
Alyar666
force-pushed
the
ai_assistant_e2e_commands_26_1
branch
from
6ff2765 to
1a3e2e5
Compare
dmirgaev
reviewed
Jun 5, 2026
dmirgaev
reviewed
Jun 5, 2026
Alyar666
force-pushed
the
ai_assistant_e2e_commands_26_1
branch
from
f36f849 to
13c29f0
Compare
command execution and grid-state edge cases — single/multi commands, local data parity, stacked operations, and empty/single-row/large/single-column/all-hidden/already-in-target-state grids (plan §1.2–§1.4, §3.1–§3.7) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
- Extract a mocked-integration grid factory (local + remote) to remove the
per-test aiIntegration boilerplate; replay canned responses in order.
- Unify assertion order (chat status first, then grid state) and the
success accessor (getSuccessMessages + getSuccessActionItems) across tests.
- Verify remote-specific behavior in 1.4.2 via getDataSource().sort() load option.
- Fix filterValue mocks (3.1.2/3.5.3/3.7.2) to use the {rootId,nodes} tree
shape the command schema expects (flat {type:'basic'} was rejected).
- Drop unused POM accessors added for sibling PRs (abort dialog, suggestions,
input/clear-chat disabled state, getAIMessages, focusAIAssistantButton, etc.).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The selectByIndexes command schema now requires a `mode: 'select' | 'deselect'`
field (strict schema). The 3.2.2/3.2.3 mocks sent `{ indexes: [...] }` without
`mode`, so validateResponse rejected the response ("invalid response") and the
tests failed in CI. Add `mode: 'select'` to both payloads.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Use the canonical getMessages (chat bubbles) / getAIMessages semantics and keep only the POM methods this PR's tests use (functional + visual), dropping unused ones.
Move the common test data and the queue-based sendRequest mock (createGridWithAIAssistant / setupAIState / sentinels) into testHelpers so all queue-based suites share one implementation instead of per-file duplicates.
Collapse the per-section fixtures into a single named fixture; keep the // === §X === markers as in-file section dividers.
…ync grid reads to t.expect Restore the scoped getWrapper override; drop await inside t.expect so TestCafe retries async grid-state assertions (Copilot review).
Alyar666
force-pushed
the
ai_assistant_e2e_commands_26_1
branch
from
13c29f0 to
164ac9a
Compare
anna-shakhova
previously approved these changes
Jun 12, 2026
Raushen
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR change?
Adds e2e TestCafe tests for the DataGrid AI Assistant — command execution and grid-state edge cases — single/multi commands, local data parity, stacked operations, and empty/single-row/large/single-column/all-hidden/already-in-target-state grids (plan §1.2–§1.4, §3.1–§3.7).
Part of splitting the AI Assistant e2e suite into per-area pull requests.