Skip to content

Commit

Permalink
Update ng version to 17
Browse files Browse the repository at this point in the history
  • Loading branch information
dxvladislavvolkov committed Nov 25, 2024
1 parent 370999e commit 5903a2b
Show file tree
Hide file tree
Showing 9 changed files with 68 additions and 867 deletions.
890 changes: 42 additions & 848 deletions packages/devextreme-schematics/package-lock.json

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions packages/devextreme-schematics/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,17 @@
],
"schematics": "./src/collection.json",
"dependencies": {
"@angular-devkit/core": "^16.2.10",
"@angular-devkit/schematics": "^16.2.10",
"@schematics/angular": "^16.2.10"
"@angular-devkit/core": "^17.2.1",
"@angular-devkit/schematics": "^17.2.1",
"@schematics/angular": "^17.2.1"
},
"devDependencies": {
"@types/jasmine": "~3.10.18",
"@types/node": "ts4.9",
"@types/node": "ts5.2",
"@types/semver": "^7.5.7",
"jasmine": "^2.99.0",
"rxjs": "^6.6.7",
"tslint": "^5.20.1",
"typescript": "^4.9.3"
"typescript": "~5.2.1"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
},
"globalNgCliVersion": {
"type":"string",
"default": "^16.2.0"
"default": "^17.2.0"
},
"empty": {
"type": "boolean",
Expand Down
17 changes: 10 additions & 7 deletions packages/devextreme-schematics/src/add-layout/index_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,19 @@ describe('layout', () => {
routing: false,
style: 'scss',
skipTests: false,
skipPackageJson: false
skipPackageJson: false,
standalone: false
};

const workspaceOptions: WorkspaceOptions = {
name: 'workspace',
version: '16.0.0'
version: '17.0.0'
};

const options: any = {
layout: 'side-nav-outer-toolbar',
resolveConflicts: 'override',
globalNgCliVersion: '^16.2.0'
globalNgCliVersion: '^17.2.0'
};

const angularSchematicsCollection = require.resolve('../../node_modules/@schematics/angular/collection.json');
Expand Down Expand Up @@ -181,7 +182,7 @@ describe('layout', () => {
const tree = await runner.runSchematic('add-layout', options, appTree);
const packageConfig = JSON.parse(tree.readContent('package.json'));

expect(packageConfig.dependencies['@angular/cdk']).toBe('~16.2.0');
expect(packageConfig.dependencies['@angular/cdk']).toBe('~17.2.0');
});

it('should update budgets if updateBudgets option is true', async () => {
Expand Down Expand Up @@ -231,7 +232,7 @@ describe('layout', () => {

const appContent = tree.readContent('/src/app/app.component.ts');
expect(appContent).toMatch(/templateUrl: '.\/app.component.html',/);
expect(appContent).toMatch(/styleUrls: \['.\/app.component.scss'\]/);
expect(appContent).toMatch(/styleUrl: '.\/app.component.scss'/);

const newAppContent = tree.readContent('/src/app/app1.component.ts');
expect(newAppContent).toMatch(/templateUrl: '.\/app1.component.html',/);
Expand Down Expand Up @@ -279,7 +280,8 @@ describe('layout', () => {
appTree = await schematicRunner.runSchematic('application', {
...appOptions,
name: 'testApp2',
projectRoot: 'projects/testApp2'
projectRoot: 'projects/testApp2',
standalone: false
}, appTree);

const runner = new SchematicTestRunner('schematics', collectionPath);
Expand All @@ -299,7 +301,8 @@ describe('layout', () => {
...appOptions,
name: 'testApp2',
prefix: 'app2',
projectRoot: 'projects/testApp2'
projectRoot: 'projects/testApp2',
standalone: false
}, appTree);

const runner = new SchematicTestRunner('schematics', collectionPath);
Expand Down
2 changes: 1 addition & 1 deletion packages/devextreme-schematics/src/add-layout/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
},
"globalNgCliVersion": {
"type":"string",
"default": "16.2.0"
"default": "17.2.0"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ describe('sample views', () => {
routing: true,
style: 'css',
skipTests: false,
skipPackageJson: false
skipPackageJson: false,
standalone: false
};

const workspaceOptions: WorkspaceOptions = {
Expand Down
3 changes: 2 additions & 1 deletion packages/devextreme-schematics/src/add-view/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ export default function(options: any): Rule {
module,
skipTests: options.skipTests,
inlineStyle: options.inlineStyle,
prefix: options.prefix
prefix: options.prefix,
standalone: false
}),
addContentToView({ name, project }) as any
];
Expand Down
3 changes: 2 additions & 1 deletion packages/devextreme-schematics/src/add-view/index_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ describe('view', () => {
routing: true,
style: 'css',
skipTests: false,
skipPackageJson: false
skipPackageJson: false,
standalone: false
};

const workspaceOptions: WorkspaceOptions = {
Expand Down
5 changes: 3 additions & 2 deletions packages/devextreme-schematics/src/install/index_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ describe('install', () => {

const workspaceOptions: WorkspaceOptions = {
name: 'workspace',
version: '16.0.0'
version: '17.0.0'
};

const angularSchematicsCollection = require.resolve('../../node_modules/@schematics/angular/collection.json');
Expand Down Expand Up @@ -86,7 +86,8 @@ describe('install', () => {
routing: true,
style: 'css',
skipTests: false,
skipPackageJson: false
skipPackageJson: false,
standalone: false
};

appTree = await schematicRunner.runSchematic('application', secondAppOptions, appTree);
Expand Down

0 comments on commit 5903a2b

Please sign in to comment.