Skip to content

[#136] πŸ› λΉŒλ“œ μ—λŸ¬ ν•΄κ²° #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KingNono1030 merged 20 commits into from
Nov 29, 2024
Merged

[#136] πŸ› λΉŒλ“œ μ—λŸ¬ ν•΄κ²° #137

KingNono1030 merged 20 commits into from
Nov 29, 2024

Conversation

@KingNono1030
Copy link
Contributor

@KingNono1030 KingNono1030 commented Nov 28, 2024 •
edited
Loading

πŸ“Œ PR ν…œν”Œλ¦Ώ

🏷️ PR νƒ€μž… (PR Type)

μ•„λž˜ ν•΄λ‹Ή 사항에 체크해 μ£Όμ„Έμš”.

  • πŸ› 버그 μˆ˜μ • (Bugfix)
  • ✨ κΈ°λŠ₯ 개발 (Feature)
  • 🎨 μ½”λ“œ μŠ€νƒ€μΌ λ³€κ²½ (Code style update) - ν¬λ§€νŒ…, 둜컬 λ³€μˆ˜ λ“±
  • ♻️ λ¦¬νŒ©ν† λ§ (Refactoring) - κΈ°λŠ₯ λ³€ν™” μ—†μŒ, API λ³€κ²½ μ—†μŒ
  • πŸ› οΈ λΉŒλ“œ κ΄€λ ¨ λ³€κ²½ (Build related changes)
  • πŸ“ λ¬Έμ„œ λ‚΄μš© λ³€κ²½ (Documentation)
  • πŸ”„ 기타 (Other) - μ„€λͺ… μž‘μ„±

πŸ“ μš”μ•½ (Summary)

PR의 λͺ©μ κ³Ό κ°„λ‹¨ν•œ μ„€λͺ…을 μ μ–΄μ£Όμ„Έμš”.

λΉŒλ“œ μ›Œλ‹ 및 λΉŒλ“œ μ—λŸ¬ ν•΄κ²°

πŸ” 상세 λ‚΄μš© (Describe your changes)

λ³€κ²½ 사항을 ꡬ체적으둜 μž‘μ„±ν•΄ μ£Όμ„Έμš”.

  • any νƒ€μž… μ‚¬μš© -> unknown
  • μ‚¬μš©λ˜μ§€ μ•ŠλŠ” λ³€μˆ˜ 제거
  • ν•¨μˆ˜μ— 리턴 νƒ€μž… μΆ”κ°€

πŸ”— κ΄€λ ¨ 이슈 λ˜λŠ” 링크 (Issue Number or Link)

이슈 λ²ˆν˜Έλ‚˜ κ΄€λ ¨ 링크가 μžˆλ‹€λ©΄ μΆ”κ°€ν•΄ μ£Όμ„Έμš”.

βœ… 체크리슀트 (Checklist)

PR μž‘μ„± μ‹œ μ•„λž˜ 사항듀을 점검해 μ£Όμ„Έμš”.

  • λΉŒλ“œκ°€ μ„±κ³΅μ μœΌλ‘œ λ˜μ—ˆλ‚˜μš”?
  • μ½”λ“œμ— 주석을 μΆ”κ°€ν–ˆλ‚˜μš”?
  • λͺ¨λ“  ν…ŒμŠ€νŠΈκ°€ ν†΅κ³Όν–ˆλ‚˜μš”?
  • κ΄€λ ¨ λ¬Έμ„œκ°€ μ—…λ°μ΄νŠΈλ˜μ—ˆλ‚˜μš”?

πŸ“Έ μŠ€ν¬λ¦°μƒ· (선택 사항)

λ³€κ²½ 사항이 UI와 관련이 μžˆλ‹€λ©΄ μŠ€ν¬λ¦°μƒ·μ„ μΆ”κ°€ν•΄ μ£Όμ„Έμš”.

image

any νƒ€μž…μ€ ky κ°€ μ œκ³΅ν•˜λŠ” httpError νƒ€μž…μœΌλ‘œ 쒁히기

πŸ“ 기타 사항

PRκ³Ό κ΄€λ ¨λœ 기타 사항이 μžˆλ‹€λ©΄ μ μ–΄μ£Όμ„Έμš”.

@KingNono1030
[#99] ✨ add Pagination component
81aaa99
@KingNono1030
[#99] ✨ add usePagination hook
80eb871
@KingNono1030
[#99] πŸ’„ update chevron-right svg with currentColor attribute
a54d8ca
@KingNono1030
[#99] ♻️ refactor button from using label and icons props to children…
35af466 
… props
@KingNono1030
[#99] ♻️ reflect changes in Clickable on module content component
3800646
@KingNono1030
[#99] βœ… add Pagination stories
aa76d6e
@KingNono1030
[#99] ✨ add extended twMerge due to the issue with merging custom cla…
beef83f 
…sses
@KingNono1030
[#99] ♻️ apply extended twMerge in clickable to test if it works
879f6dd
@KingNono1030
Merge branch 'dev' of https://github.com/DevFDev/frontend into feat/s…
480b956 
…hared-component-pagination
@KingNono1030
[#99] ♻️ separate resuable interface (UsePagination)
99d20a6
@KingNono1030
[#99] ♻️ replace clsx with twMergeEx in Pagination component
ef56aca
@KingNono1030
[#99] ♻️ add conditional className handling function in Pagination co…
57bb634 
…mponent'
@KingNono1030
[#99] 🚚 rename UsePaginationReturn into PaginationState
7d1a3e1
@KingNono1030
[#134] 🚚 rename api related type locations to types/api/...
6de651e
@KingNono1030
[#134] πŸ”§ update generate:types scripts with type saving path
2dadded
@KingNono1030
[#134] 🚚 reflect location change of type files on import lines
4987eff
@KingNono1030
[#136] πŸ› add return type to functions
fabc065
@KingNono1030
[#136] πŸ› fix any type usages by exploiting httperror interface from ky
98ad27b
@KingNono1030
[#136] πŸ—‘οΈ remove unused lines
1df414e
@KingNono1030 KingNono1030 self-assigned this Nov 28, 2024
@KingNono1030 KingNono1030 changed the title [#136] λΉŒλ“œ μ—λŸ¬ ν•΄κ²° [#136] πŸ› λΉŒλ“œ μ—λŸ¬ ν•΄κ²° Nov 28, 2024
@KingNono1030 KingNono1030 marked this pull request as ready for review November 28, 2024 12:51
yongb2n
yongb2n approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@yongb2n yongb2n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€ μœ€ν˜Έλ‹˜~~

@KingNono1030 KingNono1030 merged commit fd30d7f into dev Nov 29, 2024
2 of 3 checks passed
@KingNono1030 KingNono1030 deleted the fix/solve-build-errors branch November 30, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yongb2n yongb2n yongb2n approved these changes

@yellowjang yellowjang Awaiting requested review from yellowjang

Assignees

@KingNono1030 KingNono1030

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FIX] λΉŒλ“œ μ—λŸ¬ ν•΄κ²°

3 participants

@KingNono1030 @yongb2n