Skip to content

Conversation

@KingNono1030
Copy link
Contributor

@KingNono1030 KingNono1030 commented Dec 3, 2024

πŸ“Œ PR ν…œν”Œλ¦Ώ

🏷️ PR νƒ€μž… (PR Type)

μ•„λž˜ ν•΄λ‹Ή 사항에 체크해 μ£Όμ„Έμš”.

  • πŸ› 버그 μˆ˜μ • (Bugfix)
  • ✨ κΈ°λŠ₯ 개발 (Feature)
  • 🎨 μ½”λ“œ μŠ€νƒ€μΌ λ³€κ²½ (Code style update) - ν¬λ§€νŒ…, 둜컬 λ³€μˆ˜ λ“±
  • ♻️ λ¦¬νŒ©ν† λ§ (Refactoring) - κΈ°λŠ₯ λ³€ν™” μ—†μŒ, API λ³€κ²½ μ—†μŒ
  • πŸ› οΈ λΉŒλ“œ κ΄€λ ¨ λ³€κ²½ (Build related changes)
  • πŸ“ λ¬Έμ„œ λ‚΄μš© λ³€κ²½ (Documentation)
  • πŸ”„ 기타 (Other) - μ„€λͺ… μž‘μ„±

πŸ“ μš”μ•½ (Summary)

PR의 λͺ©μ κ³Ό κ°„λ‹¨ν•œ μ„€λͺ…을 μ μ–΄μ£Όμ„Έμš”.

  • νƒ€μž…λͺ…이 의미적으둜 μ‹€μ œ μ“°μ΄λŠ” μš”μ²­κ³Ό μΌμΉ˜ν•˜μ§€ μ•ŠλŠ” κ²½μš°κ°€ μžˆμ–΄ λ³€ν™˜ν•˜κ³ μž ν•©λ‹ˆλ‹€.

image

  • 예) μ‹€μ œλ‘œλŠ” νŒ€ λͺ¨μ§‘글에 λŒ€ν•œ get κ³Ό post μš”μ²­μΈλ°, μ΄λ¦„λ§ŒμœΌλ‘œλŠ” νŒ€μ„ μƒμ„±ν•˜λŠ” μš”μ²­μ˜ μΈν„°νŽ˜μ΄μŠ€μ²˜λŸΌ λ³΄μž…λ‹ˆλ‹€.

πŸ” 상세 λ‚΄μš© (Describe your changes)

λ³€κ²½ 사항을 ꡬ체적으둜 μž‘μ„±ν•΄ μ£Όμ„Έμš”.

  • μ£Όμš” 변경점 μ˜ˆμ‹œ: "λ²„νŠΌ μŠ€νƒ€μΌ λ³€κ²½" λ“±

πŸ”— κ΄€λ ¨ 이슈 λ˜λŠ” 링크 (Issue Number or Link)

이슈 λ²ˆν˜Έλ‚˜ κ΄€λ ¨ 링크가 μžˆλ‹€λ©΄ μΆ”κ°€ν•΄ μ£Όμ„Έμš”.


βœ… 체크리슀트 (Checklist)

PR μž‘μ„± μ‹œ μ•„λž˜ 사항듀을 점검해 μ£Όμ„Έμš”.

  • λΉŒλ“œκ°€ μ„±κ³΅μ μœΌλ‘œ λ˜μ—ˆλ‚˜μš”?
  • μ½”λ“œμ— 주석을 μΆ”κ°€ν–ˆλ‚˜μš”?
  • λͺ¨λ“  ν…ŒμŠ€νŠΈκ°€ ν†΅κ³Όν–ˆλ‚˜μš”?
  • κ΄€λ ¨ λ¬Έμ„œκ°€ μ—…λ°μ΄νŠΈλ˜μ—ˆλ‚˜μš”?

πŸ“Έ μŠ€ν¬λ¦°μƒ· (선택 사항)

λ³€κ²½ 사항이 UI와 관련이 μžˆλ‹€λ©΄ μŠ€ν¬λ¦°μƒ·μ„ μΆ”κ°€ν•΄ μ£Όμ„Έμš”.


πŸ“ 기타 사항

PRκ³Ό κ΄€λ ¨λœ 기타 사항이 μžˆλ‹€λ©΄ μ μ–΄μ£Όμ„Έμš”.

@KingNono1030 KingNono1030 self-assigned this Dec 3, 2024
@KingNono1030
Copy link
Contributor Author

@yellowjang
image

@KingNono1030
Copy link
Contributor Author

KingNono1030 commented Dec 3, 2024

@yellowjang
νŒ€ λͺ¨μ§‘κΈ€μ˜ μ‘°νšŒμ™€ νŒ€ 멀버 μ‘°νšŒμ™€ κ΅¬λΆ„λ˜λŠ”κ²Œ 쒋을 것 κ°™λ‹€λŠ” 의견

@KingNono1030 KingNono1030 marked this pull request as ready for review December 3, 2024 08:53
Copy link
Contributor

@yellowjang yellowjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

νƒ€μž…λͺ… λ³€κ²½ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€! :) κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€~~

/*
path: '/v1/team/{teamId}/close'
PATCH: νŒ€ λͺ¨μ§‘κΈ€ λͺ¨μ§‘ 마감
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'νŒ€ λͺ¨μ§‘κΈ€ λͺ¨μ§‘ 마감' νƒ€μž… μΆ”κ°€ μ˜ˆμ •μ΄μ‹ κ±΄κ°€μš” ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν•΄λ‹Ή λ©”μ„œλ“œλŠ” μš”κ΅¬ν•˜λŠ” reqeust body 도 μ—†κ³ , response 에 λŒ€ν•΄μ„œλ„

{
  "isSuccess": true,
  "code": "COMMON200",
  "message": "λͺ¨μ§‘ μƒνƒœκ°€ λ§ˆκ°λ˜μ—ˆμŠ΅λ‹ˆλ‹€."
}

result κ°€ λΉ„μ–΄μ Έ μžˆλŠ” μ±„λ‘œ λ°˜ν™˜μ΄ λ˜μ–΄μ„œ, reponse 라고 λ§Œλ“€ μΈν„°νŽ˜μ΄μŠ€κ°€ μ—†μŠ΅λ‹ˆλ‹€. κ·Έλž˜μ„œ μ£Όμ„μœΌλ‘œλ§Œ μž‘μ„±ν–ˆμŠ΅λ‹ˆλ‹€ !

@KingNono1030 KingNono1030 merged commit 09c0585 into dev Dec 3, 2024
2 of 3 checks passed
@KingNono1030 KingNono1030 deleted the chore/update-api-related-types branch December 3, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants