Skip to content

Conversation

@KingNono1030
Copy link
Contributor

@KingNono1030 KingNono1030 commented Nov 6, 2024

๐Ÿ“Œ PR ํ…œํ”Œ๋ฆฟ

๐Ÿท๏ธ PR ํƒ€์ž… (PR Type)

์•„๋ž˜ ํ•ด๋‹น ์‚ฌํ•ญ์— ์ฒดํฌํ•ด ์ฃผ์„ธ์š”.

  • ๐Ÿ› ๋ฒ„๊ทธ ์ˆ˜์ • (Bugfix)
  • โœจ ๊ธฐ๋Šฅ ๊ฐœ๋ฐœ (Feature)
  • ๐ŸŽจ ์ฝ”๋“œ ์Šคํƒ€์ผ ๋ณ€๊ฒฝ (Code style update) - ํฌ๋งคํŒ…, ๋กœ์ปฌ ๋ณ€์ˆ˜ ๋“ฑ
  • โ™ป๏ธ ๋ฆฌํŒฉํ† ๋ง (Refactoring) - ๊ธฐ๋Šฅ ๋ณ€ํ™” ์—†์Œ, API ๋ณ€๊ฒฝ ์—†์Œ
  • ๐Ÿ› ๏ธ ๋นŒ๋“œ ๊ด€๋ จ ๋ณ€๊ฒฝ (Build related changes)
  • ๐Ÿ“ ๋ฌธ์„œ ๋‚ด์šฉ ๋ณ€๊ฒฝ (Documentation)
  • ๐Ÿ”„ ๊ธฐํƒ€ (Other) - ์„ค๋ช… ์ž‘์„ฑ

๐Ÿ“ ์š”์•ฝ (Summary)

PR์˜ ๋ชฉ์ ๊ณผ ๊ฐ„๋‹จํ•œ ์„ค๋ช…์„ ์ ์–ด์ฃผ์„ธ์š”.

https://stackoverflow.com/questions/72851548/permission-denied-to-github-actionsbot

์œ„ ๋‹ต๋ณ€์„ ์ฐธ๊ณ ํ•ด์„œ ์“ฐ๊ธฐ ๊ถŒํ•œ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.


๐Ÿ” ์ƒ์„ธ ๋‚ด์šฉ (Describe your changes)

๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ๊ตฌ์ฒด์ ์œผ๋กœ ์ž‘์„ฑํ•ด ์ฃผ์„ธ์š”.

  • ์ฃผ์š” ๋ณ€๊ฒฝ์  ์˜ˆ์‹œ: "๋ฒ„ํŠผ ์Šคํƒ€์ผ ๋ณ€๊ฒฝ" ๋“ฑ

๐Ÿ”— ๊ด€๋ จ ์ด์Šˆ ๋˜๋Š” ๋งํฌ (Issue Number or Link)

์ด์Šˆ ๋ฒˆํ˜ธ๋‚˜ ๊ด€๋ จ ๋งํฌ๊ฐ€ ์žˆ๋‹ค๋ฉด ์ถ”๊ฐ€ํ•ด ์ฃผ์„ธ์š”.


โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ (Checklist)

PR ์ž‘์„ฑ ์‹œ ์•„๋ž˜ ์‚ฌํ•ญ๋“ค์„ ์ ๊ฒ€ํ•ด ์ฃผ์„ธ์š”.

  • ์ฝ”๋“œ์— ์ฃผ์„์„ ์ถ”๊ฐ€ํ–ˆ๋‚˜์š”?
  • ๋ชจ๋“  ํ…Œ์ŠคํŠธ๊ฐ€ ํ†ต๊ณผํ–ˆ๋‚˜์š”?
  • ๊ด€๋ จ ๋ฌธ์„œ๊ฐ€ ์—…๋ฐ์ดํŠธ๋˜์—ˆ๋‚˜์š”?

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท (์„ ํƒ ์‚ฌํ•ญ)

๋ณ€๊ฒฝ ์‚ฌํ•ญ์ด UI์™€ ๊ด€๋ จ์ด ์žˆ๋‹ค๋ฉด ์Šคํฌ๋ฆฐ์ƒท์„ ์ถ”๊ฐ€ํ•ด ์ฃผ์„ธ์š”.


๐Ÿ“ ๊ธฐํƒ€ ์‚ฌํ•ญ

PR๊ณผ ๊ด€๋ จ๋œ ๊ธฐํƒ€ ์‚ฌํ•ญ์ด ์žˆ๋‹ค๋ฉด ์ ์–ด์ฃผ์„ธ์š”.

@KingNono1030 KingNono1030 self-assigned this Nov 6, 2024
@KingNono1030 KingNono1030 requested a review from yongb2n November 6, 2024 09:30
@yongb2n yongb2n merged commit 9dba783 into dev Nov 7, 2024
1 check passed
@yongb2n yongb2n deleted the chore/update-github-workflow-file branch November 7, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants