Skip to content

PROD-276: Send custom events for various events across stackbot to go… #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aashil wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PROD-276: Send custom events for various events across stackbot to go… #70

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40343af
PROD-276: Send custom events for various events across stackbot to go…
Sep 13, 2016
d372ff3
PROD-276: Send custom event for recording the source of the search (s…
Sep 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions default/src/app/search/search.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export class SearchComponent {
doSearch(searchField: any) {
this.queryService.doQuery(searchField, 'site-search').subscribe(
data => {
ga('send', 'event', 'Search', 'source', 'site-search');
Copy link

@frankcarey frankcarey Sep 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move these to before the the doQuery()

// If when data is returned from a query with a redirect set, do the redirect.
if (data['payload']['redirect']) {
this._redirect(data['payload']['redirect']);
Expand All @@ -67,6 +68,7 @@ export class SearchComponent {
if (parameters['q'] != null) {
this.queryService.doQuery(parameters['q'], 'omnibox').subscribe(
response => {
ga('send', 'event', 'Search', 'source', 'omnibox');
return;
}, error => {
console.log('Error happened: ' + error);
Expand Down