Fix warnings part 1#3251
Merged
Martí Climent (marticliment) merged 9 commits intoDevolutions:mainfrom Feb 5, 2025
Merged
Conversation
…g braces for foreach. Remove redundant else. Fix other warnings
Adam Stachowicz (Saibamen)
changed the title
mrixner
reviewed
Feb 5, 2025
Contributor
Author
|
Martí Climent (@marticliment) Can you please review this? I'm still fixing merge conflicts. |
Martí Climent (marticliment)
approved these changes
Feb 5, 2025
Martí Climent (marticliment)
merged commit 550a8b3
into
Devolutions:main
2 checks passed
Collaborator
|
Hey Adam Stachowicz (@Saibamen), I really appreciate the effort put into improving the codebase, but please do not push PRs with style changes (e.g. replacing new() with [], adding/removing optional brackets, spaces after the if clause, etc.), since they are very time-consuming to review, and don't offer a real benefit on code performance or efficiency. Thanks for the effort! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unuses usings. Remove redundant (). Fix one CS4014. Add missing braces for foreach. Remove redundant else. Fix other warnings