Skip to content

WinGet Code Handling Modifications #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martí Climent (marticliment) merged 13 commits into from
Mar 5, 2025
Merged

WinGet Code Handling Modifications #3339

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ffba313
Mark an uninstall as successful if there is no package to uninstall
mrixner Jan 21, 2025
f4cc248
Ignore updates where install technology differs
mrixner Feb 21, 2025
1c85526
Remove the success case for winget's "application not found" return code
mrixner Mar 1, 2025
b0a133c
Add a 'hide non-applicable updates' setting to WinGet
mrixner Mar 1, 2025
8f9d174
Merge branch 'main' into winget-code-correction
mrixner Mar 1, 2025
5cf5d66
Merge branch 'winget-code-correction' of https://github.com/mrixner/U…
mrixner Mar 1, 2025
2666773
Add a log when an update is ignored
mrixner Mar 1, 2025
4388c03
Merge branch 'main' into winget-code-correction
mrixner Mar 2, 2025
e9c4a80
Update WinGetPkgOperationHelper.cs
mrixner Mar 2, 2025
37aefa4
Update WinGetPkgOperationHelper.cs
mrixner Mar 2, 2025
b12e46c
Merge branch 'main' into pr/3339
marticliment Mar 5, 2025
25e8ff3
Merge branch 'winget-code-correction' of https://github.com/mrixner/U…
marticliment Mar 5, 2025
1790c39
Minor changes for coherence with codebase
marticliment Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/UniGetUI.PackageEngine.Managers.WinGet/Helpers/WinGetPkgOperationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using UniGetUI.Core.SettingsEngine;
using UniGetUI.Core.Tools;
using UniGetUI.PackageEngine.Classes.Manager.BaseProviders;
using UniGetUI.PackageEngine.Classes.Packages.Classes;
using UniGetUI.PackageEngine.Enums;
using UniGetUI.PackageEngine.Interfaces;

Expand Down Expand Up @@ -147,10 +148,11 @@ protected override OperationVeredict _getOperationResult(
return OperationVeredict.Failure;
}

if (uintCode == 0x8A15002B)
{
return OperationVeredict.Failure;
}
if (uintCode == 0x8A15002B)
{
IgnoredUpdatesDatabase.Add(IgnoredUpdatesDatabase.GetIgnoredIdForPackage(package), package.Version);
return OperationVeredict.Failure;
}

if (uintCode == 0x8A15010D || uintCode == 0x8A15004F || uintCode == 0x8A15010E)
{
Expand Down Expand Up @@ -180,6 +182,12 @@ protected override OperationVeredict _getOperationResult(
return OperationVeredict.AutoRetry;
}

if (uintCode == 0x8A150014 && operation is OperationType.Uninstall)
{
// Application not found
return OperationVeredict.Success;
}

return OperationVeredict.Failure;
}

Expand Down