Skip to content

fix: prevent duplicate update operations in queue (#4131) #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martí Climent (marticliment) merged 3 commits into from
Oct 14, 2025
Merged

fix: prevent duplicate update operations in queue (#4131) #4171

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
096a2fb
fix: prevent duplicate update operations in queue (#4131)
GioAbq Oct 10, 2025
d98425c
fix: move duplicate detection to UpdateAll methods only
GioAbq Oct 12, 2025
3733638
test: add duplicate detection tests for issue #4131
GioAbq Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/UniGetUI/AppOperationHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,20 @@ public static void Install(IReadOnlyList<IPackage> packages, TEL_InstallReferral
return null;
}

// Check for duplicate operations already in the queue
var existingOperation = _operationList
.Where(x => x.Operation is UpdatePackageOperation updateOp
&& updateOp.Package.GetHash() == package.GetHash()
&& (x.Operation.Status is OperationStatus.InQueue or OperationStatus.Running))
.Select(x => x.Operation)
.FirstOrDefault();

if (existingOperation is not null)
{
Logger.Info($"Update operation for package {package.Id} is already queued or running. Skipping duplicate.");
return existingOperation;
}

var options = await InstallOptionsFactory.LoadApplicableAsync(package, elevated, interactive, no_integrity);
var operation = new UpdatePackageOperation(package, options, ignoreParallel, req);
operation.OperationSucceeded += (_, _) => TelemetryHandler.UpdatePackage(package, TEL_OP_RESULT.SUCCESS);
Expand Down
Loading