Make general dc path less important #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works on my local deployment, however, we might need to make the path regular expression less generic so this isn't a problem in the future (maybe even write some tests for it!) |
gfrn
reviewed
Jul 3, 2023
Co-authored-by: Guilherme Francisco <[email protected]>
|
OK, will create ticket to write tests, not sure that the reg ex can be less because it is matching every segment of the path which some parts can have any values |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path for DC page was made general so that it could accept arguments in any order but having done this it now takes the path from other routes. Move it doen the routing table so it matches last instead of first.