Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1257: Allow population of source fields #769

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented May 3, 2024

JIRA ticket: LIMS-1257

Summary:

Karl has added a source column to the BLSample, Container, Dewar and Shipping tables. By default it gets populated with the user name of the current database user, but we should allow something more descriptive in there, for eg IceBear, future web-based CSV uploader etc

Changes:

  • Add a 'SOURCE' parameter allowed in Shipment.php and Sample.php
  • Default it to null
  • Put it in insert statements, but if it is null, use the current database user as that is better than nothing

To test:

  • Create a shipment in Synchweb with at least one dewar, container and puck. Check the 4 source columns are all populated with a non-null user name such as ispyb_web@% or synchweb_dev@% (actual username depends on your dev setup)
  • Repeat adding another dewar to the shipment, as that uses a different function to dewars created with the shipment
  • Use Firefox's "Edit and Resend" functionality to repeat the creation of each, adding a SOURCE parameter each time, check this goes into the database. Dewars created at the same time as the shipment will have the same source.
  • Alternatively, use the Selenium API test (https://github.com/DiamondLightSource/SynchWeb-Selenium/blob/main/tests/mx/test_mx_shipping_api.py) to create Shipments/Dewars/Pucks/Samples, and add a source value when doing so. Check each goes into the database.

@ndg63276 ndg63276 changed the base branch from prerelease to master June 24, 2024 09:35
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R3.2 July 9, 2024 11:59
@ndg63276 ndg63276 merged commit 0390fd0 into pre-release/2024-R3.2 Jul 9, 2024
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1257/allow-population-of-source-fields branch July 9, 2024 13:20
ndg63276 added a commit that referenced this pull request Jul 23, 2024
* LIMS-1319: Show dose for all data collection types (#791)

* LIMS-954: Add ability to edit manufacturer serial no on dewars (#652)

* LIMS-1276: Add printed date to shipping labels (#755)

* LIMS-902: Clear sessionId from containers when requesting a dewar transfer (#673)

* LIMS-277: Fix sample changer view scaling (#794)

* LIMS-121: Allow use of VMXm Gridboxes and Cartridges (#732)

* LIMS-1257: Allow population of source fields (#769)

* LIMS-1382: Add message to users about using the shipping service (#801)

---------

Co-authored-by: Mark Williams <[email protected]>
Co-authored-by: Guilherme Francisco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants