Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-277: Fix sample changer view scaling #794

Merged

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-277

Summary:

The sample changer view (/dc/sc/visit/) scales weirdly, depending on the number of pucks available on the beamline.

Changes:

  • Force one of two possible aspect ratios, either 1.5 (10 pucks or less) or 0.4 (more than 10 pucks)

To test:

  • Set up 3 beamlines in config.json with 10, 14 and 37 pucks, eg:
        "pucks": {
                "i03": 37,
                "i19-1": 14,
                "i19-2": 10
        },
  • Go to a visit on each beamline, and click on the Sample Changer view, eg /dc/sc/visit/cm37235-3
  • Check the view looks reasonable with each number of pucks. If 10 pucks or less, the sample changer view is smaller, if more than 10 pucks, the view should be full width.
  • Go back to the visit, if there is a roll out sample changer view from the right hand side of the screen, check that looks ok (appears to be MX, live visits, only)

@gfrn
Copy link
Collaborator

gfrn commented Jun 28, 2024

Unrelated bug: visiting /dc/sc/visit/cm37235-3 by clicking the sample changer button works, but accessing it through the URL doesn't, results in a mismatched route

@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R3.2 July 9, 2024 11:54
@ndg63276 ndg63276 merged commit b22afc0 into pre-release/2024-R3.2 Jul 9, 2024
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-277/fix-sample-changer-view-scaling branch July 9, 2024 12:01
ndg63276 added a commit that referenced this pull request Jul 23, 2024
* LIMS-1319: Show dose for all data collection types (#791)

* LIMS-954: Add ability to edit manufacturer serial no on dewars (#652)

* LIMS-1276: Add printed date to shipping labels (#755)

* LIMS-902: Clear sessionId from containers when requesting a dewar transfer (#673)

* LIMS-277: Fix sample changer view scaling (#794)

* LIMS-121: Allow use of VMXm Gridboxes and Cartridges (#732)

* LIMS-1257: Allow population of source fields (#769)

* LIMS-1382: Add message to users about using the shipping service (#801)

---------

Co-authored-by: Mark Williams <[email protected]>
Co-authored-by: Guilherme Francisco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants