Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1240: Dont use shortComments LIKE 'EDNA%' #795

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Jul 1, 2024

JIRA ticket: LIMS-1240

Summary:

We no longer populate the Screening.shortComments with 'EDNA Strategy 1', instead we just use 'Strategy 1'. Using the program version is more generic for getting any EDNA strategy, or use 'Strategy%' when comparing EDNA strategies.

Changes:

  • Use programVersion instead of shortComments to search for EDNA results
  • Fix accessing pipeline stats
  • Search for 'Strategy%' instead of 'EDNA%' in pipeline stats, which has been used since 2018.

To test:

  • Go to a container with samples that have been screened, eg /containers/cid/301095, inspect the GET to /api/sample, check that some of the samples have non-null values for SCRESOLUTION and SCCOMPLETENESS
  • Go to Stats, then Pipeline Stats (this should take you to /statistics/pl). Check some average processing times appear for the last few years, for different strategies.

@gfrn gfrn self-requested a review July 9, 2024 12:28
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R3.3 July 23, 2024 09:51
@ndg63276 ndg63276 merged commit 1c34347 into pre-release/2024-R3.3 Jul 23, 2024
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1240/dont-use-shortcomments-for-edna branch August 12, 2024 14:41
ndg63276 added a commit that referenced this pull request Aug 12, 2024
* LIMS-1370: Handle errors from the shipping service (#804)

* LIMS-1330: Use experimentTypeId if specified (#796)

* LIMS-1240: Dont use shortComments LIKE 'EDNA%' (#795)

* LIMS-1350: Display crystal snapshots even if zipped (#807)

* LIMS-1369: Make fault report titles editable (#802)

* LIMS-1341: Allow entry of SMILES codes (#793)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants