Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-1379: Grid scan heatmaps are not snaked correctly #800

Merged
merged 1 commit into from
Aug 16, 2024
Merged

LIMS-1379: Grid scan heatmaps are not snaked correctly #800

merged 1 commit into from
Aug 16, 2024

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1379

Summary:

You can view heatmaps for grid scans on plates via the container view, eg https://ispyb.diamond.ac.uk/containers/cid/295986 well 3. But the snaked parameter is being ignored, so alternate rows of the grid scan are flipped from what they should be. This creates a stripy and mirrored effect.

image

Changes:

  • Convert the SNAKED parameter to a number, as the javascript checks for === 1 (see here)
    • Could also have changed the javascript but this way is consistent with other fields.

To test:

  • Go to /containers/cid/295986 well 3, check the stripy and mirrored effect is gone

image

@gfrn gfrn self-requested a review July 17, 2024 10:44
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R4.1 August 16, 2024 12:44
@ndg63276 ndg63276 merged commit c1a523e into pre-release/2024-R4.1 Aug 16, 2024
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1379/grid-scan-heat-maps-not-snaked branch August 27, 2024 09:25
ndg63276 added a commit that referenced this pull request Sep 3, 2024
@ndg63276
Merge pre-release/2024-R4.1 into master (#824)
c96ea08 
* LIMS-1355: Make OAuth2 support more generic (#792)

* LIMS-1383, LIMS-160, LIMS-269: Improve reprocessing (#812)

* LIMS-1379: Grid scan heatmaps are not snaked correctly (#800)

* LIMS-1119: Show text on small buttons (#798)

* LIMS-700: Allow bulk editing of protein (#808)

* LIMS-1371, LIMS-1372: Add search and 'My Groups' to Sample Groups page (#579)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfrn gfrn gfrn approved these changes

Assignees
No one assigned
Labels
Ready to Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndg63276 @gfrn @NKatti2011