Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1368: Fix incorrectly summed dose for DC groups when filtered #803

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1368

Summary:

When data collection groups are shown, the total dose is displayed by summing the dose for each data collection. But when you filter the view by "Auto Integrated", the extra joins to AutoProcIntegration etc mean extra rows are summed.

Changes:

  • Join to a subquery of simply dataCollectionGroupId and sum(totalAbsorbedDose) for each data collection group
  • Use the number from the subquery

To test:

  • Go to /samples/sid/5653602, look at the first data collection, the Total Dose should be 21.75MGy
  • Click the Auto Integrated filter, the total dose should not change
  • Check the same is true for the Data Collections and Full Collections filters
  • Go to /samples/sid/5653041 and check the Phasing filter
  • Go to /dc/visit/mx35120-12, look at the top data collection, check the Total Dose doesn't change with the Auto Integrated filter on/off
  • Go to /dc/visit/mx35120-12/dcg/12149523, check the dose for each data collection says 10.88MGy and doesn't change with the Auto Integrated filter on/off

@ndg63276 ndg63276 requested a review from NKatti2011 July 24, 2024 10:46
@NKatti2011
Copy link
Collaborator

Ready to Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants