Correlation id #197
Draft
Correlation id #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worker transactions now in #202 |
|
@keithralphs does this PR contain anything useful to you in your opentelemetery endeavours? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to deal with correlation id via CLI and rest api.
The concept is, whatever is calling the rest API will already have some correlation id for the plan to be run.
This PR should allow the client to call the server via the CLI to:
I'm not yet sure the best way of restfully accomplishing these tasks. So far, I've just done everything through the CLI run_plan function, but this handles the active mq subscriptions directly which doesn't seem smart. It seems better to have some sort of 'cache' of bluesky events that can be accessed by the rest API to get the latest status.