Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update documentation #248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rosesyrett
Copy link
Contributor

This repository has changed a bit and the docs need to be updated.

@rosesyrett
Copy link
Contributor Author

Will also want to update lifecycle.rst

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #248 (a113132) into main (ea63806) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   88.57%   88.57%           
=======================================
  Files          41       41           
  Lines        1339     1339           
=======================================
  Hits         1186     1186           
  Misses        153      153           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment on lines +41 to +42
publishing Bluesky event documents to the message bus. This object is injected as a dependency into
(using the FastAPI_ dependency injection system) to all REST endpoints, exposing their methods to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
publishing Bluesky event documents to the message bus. This object is injected as a dependency into
(using the FastAPI_ dependency injection system) to all REST endpoints, exposing their methods to
publishing Bluesky event documents to the message bus. This object is injected as a dependency (using the FastAPI_ dependency injection system) into the REST endpoints, exposing their methods to

@@ -37,10 +37,17 @@ the known expectations of the plan, passes it to the ``RunEngine`` and handles a
The Service Object
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now called handler but maybe should have a better name

-------------------------

If you change any of the code in src/blueapi/service/main, it is imperative that
you update the openapi schema to reflect these changes. There is a test to check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add reason why

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check how this shows up in dark mode

Use the command line interface (CLI)
====================================

Blueapi comes pacakged with a simple click based CLI. You can start the server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete first sentence


Blueapi comes pacakged with a simple click based CLI. You can start the server
and then query it for plans and devices, as well as ask it to run a plan, through
the CLI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the CLI.
the bundled CLI client.

and then query it for plans and devices, as well as ask it to run a plan, through
the CLI.

Starting the server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stan-dot
Copy link
Collaborator

this is by definition out of date, petition to close @callumforrester

@callumforrester
Copy link
Collaborator

@stan-dot would you mind reviewing it and making sure there is no useful information that's still relevant? If so you can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants