Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to ref p38 dodal #281

Closed
wants to merge 11 commits into from
Closed

Changes to ref p38 dodal #281

wants to merge 11 commits into from

Conversation

keithralphs
Copy link
Contributor

No description provided.

@keithralphs keithralphs temporarily deployed to prod July 26, 2023 15:05 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #281 (6ca9136) into main (1dd6b0f) will not change coverage.
Report is 8 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          41       41           
  Lines        1412     1412           
=======================================
  Hits         1263     1263           
  Misses        149      149           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DiamondJoseph DiamondJoseph temporarily deployed to prod July 28, 2023 13:58 — with GitHub Actions Inactive
@DiamondJoseph DiamondJoseph temporarily deployed to prod August 4, 2023 10:26 — with GitHub Actions Inactive
@DiamondJoseph DiamondJoseph temporarily deployed to prod August 4, 2023 12:11 — with GitHub Actions Inactive
@DiamondJoseph DiamondJoseph temporarily deployed to prod August 4, 2023 13:08 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 8, 2023 14:48 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 9, 2023 12:44 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 11, 2023 09:52 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 11, 2023 10:10 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 11, 2023 10:23 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 11, 2023 10:34 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 11, 2023 10:46 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 11, 2023 12:38 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 11, 2023 13:43 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 11, 2023 13:59 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 11, 2023 14:11 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 11, 2023 14:30 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 11, 2023 14:40 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 14, 2023 09:28 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 14, 2023 09:40 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 14, 2023 10:10 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 14, 2023 12:55 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 14, 2023 14:35 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 14, 2023 14:46 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 15, 2023 09:18 — with GitHub Actions Inactive
@@ -35,6 +35,9 @@ spec:
- secret:
name: {{ . }}
{{- end }}
- name: plans
hostPath:
path: "/dls_sw/p38/software/bluesky_plans"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un-hardcode this and get (this/these) from values.yaml if it exists

Comment on lines +56 to +58
env:
- name: PYTHONPATH
value: /plans
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calllum wants to only allow python modules and not just a random folder

@keithralphs keithralphs temporarily deployed to prod August 15, 2023 12:36 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 15, 2023 14:47 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 15, 2023 14:58 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 17, 2023 12:07 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 17, 2023 13:25 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 17, 2023 13:38 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 17, 2023 13:51 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 18, 2023 12:36 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 18, 2023 12:51 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 25, 2023 10:49 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 25, 2023 11:27 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 25, 2023 12:21 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod August 29, 2023 12:47 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod September 13, 2023 08:10 — with GitHub Actions Inactive
@keithralphs keithralphs temporarily deployed to prod September 13, 2023 10:37 — with GitHub Actions Inactive
@stan-dot
Copy link
Collaborator

unclear ref changes, petition to close @callumforrester

@callumforrester
Copy link
Collaborator

Yep, no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants