Add event type filtering to listener command #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumforrester
force-pushed
the
listener-filtering
branch
from
7a0c73b
to
c6bc748
Compare
callumforrester
commented
Apr 22, 2024
src/blueapi/config.py
Outdated
Comment on lines
74
to
88
| class LoggingLevelConfig(BlueapiBaseModel): | ||
| """ | ||
| Log levels of blueapi applications and components | ||
| """ | ||
|
|
||
| service: LogLevel = "INFO" | ||
| cli: LogLevel = "ERROR" | ||
|
|
||
|
|
||
| class LoggingConfig(BlueapiBaseModel): | ||
| level: LogLevel = "INFO" | ||
| """ | ||
| Config for how blueapi logs behave | ||
| """ | ||
|
|
||
| level: LoggingLevelConfig = Field(default_factory=LoggingLevelConfig) |
There was a problem hiding this comment.
I don't think this is needed any more, the CLI and server just have entirely separate configurations, so do not need a shared configuration with separate elements.
This is a refactor to avoid direct access to handler components from the REST app. To allow further changes to the handler management of the worker and run engine in future. In preparation for #317
Just a try except around the connection attempt. It displays the failure to connect in the logs but does not fail fast. It allows the rest of the application setup to complete just without a connection to a message bus. You can then `crtl+c` to close it. I was advised to just add this fix until the subprocess work is done then we can re-address the behaviour we want.
Create SubprocessHandler as additional BlueskyHandler implementation to forward calls to a subprocess. This is to allow a new REST endpoint with the result of reloading the plans and devices without having to restart the service. Additionally the API version is incremented due to new schema and a reference to delete_task replaced with clear_pending_task which was missed in a previous PR. Further improvements required in later PRs.
Closes #369 The validated and processed parameters from a plan request were being cached inside the `Task` class because they were needed in two separate threads. Unfortunately, with the introduction of the subprocess (#343), pickling was causing issues with the cached object (see #369 for more details). This PR is the simplest solution: remove the cache and generate the parameters twice. It also adds regression tests for the bug case in #369
…374) - Removes the mounting of a manually formatted secret containing the credentials
Changes: - Add logo from #338 - Improve architecture diagram on docs landing page based on feedback --------- Co-authored-by: DiamondJoseph <[email protected]>
quick renaming 36 refs and delete the class
closes issue #233
add instruction how to escape a failure mode when running the image
Convert project from python3-pip-skeleton to python-copier-template version 2.0.1. This involves numerous changes most notably restructuring of documentation into a single manual. Additionally many of the pre-commit tools have been replaced with ruff. The ruff ruleset is slightly different to the previous tools so minor changes have been made to the source code. Extensions to this task for completion later: * Convert all documentation to markdown * Fix relative image handling in README * Add more detail about running blueapi tests * Enable ruff's "pyupgrade" ruleset
Issues fixed automatically. This also removes typing_extensions as we are not supporting older versions of Python now. Fixes #393.
Change owner to core data acq group and add Athena system reference
The logo inclusion is following the approach adopted by other DLS copier based projects e.g. scanspec.
This is mostly to fix the CI on main before the change to drop python 3.9 is merged and another PR submitted to adapt to latest ophyd-async and dodal changes.
Fixes #416 Remove Python3.9 check from CI and enforce python>=3.10 in pyproject.toml. Adapt to PEP 604 type hint changes and other minor import changes. --------- Co-authored-by: Joe Shannon <[email protected]>
Following on from discussion at: DiamondLightSource/python-copier-template#136 Specifically, ADRs 0001 & 0002 will remain static in the python-copier-template and no further ADRs will be added to the template. This will ensure there are no conflicts going forward with future template updates.
Stomp has changed it's name to `stomp-py` rather than `stomp.py`. This fixes the change
#384 Moved the coverage settings in pyproject.toml from the pytest settings to the tox command. Some merge conflict kept the settings in both places, which interferes with vscode debugging. This PR removes the redundant settings.
This is required for installing python packages at runtime. It was previously present in the non-slim python container used before but this was accidentally removed with the switch to the copier template. Fixes #445.
Add new restartOnConfigChange property. This will cause the deployment to be restarted if the config is changed, e.g. the set of plans or device modules are updated, when running helm upgrade. Use a variation of approach at: https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments Fixes 451.
|
I think this PR badly needs to be rebased on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.